After applying all 5 patches, the test suite passes for me in both Python 2.7 and 3.2 on Ubuntu 12.10.
Visual review of the patches:
* I'm not sure that you need the lambda in test_dbus_exception_convert_str_fail(). It looks weird but I haven't tried it without the lambda.
* Can you provide some more detail about the weird up-chaining you're seeing with Exception.__unicode__?
* I'd probably swap this code around (I always dislike testing a negative when testing a positive will do just as well):
+ if self._dbus_error_name is not None: + return '%s: %s' % (self._dbus_error_name, s) + else: + return s
i.e.
if self._dbus_error_name is None: return s else: return '%s: %s' % (self._dbus_error_name, s)
After applying all 5 patches, the test suite passes for me in both Python 2.7 and 3.2 on Ubuntu 12.10.
Visual review of the patches:
* I'm not sure that you need the lambda in test_dbus_ exception_ convert_ str_fail( ). It looks weird but I haven't tried it without the lambda.
* Can you provide some more detail about the weird up-chaining you're seeing with Exception. __unicode_ _?
* I'd probably swap this code around (I always dislike testing a negative when testing a positive will do just as well):
+ if self._dbus_ error_name is not None: dbus_error_ name, s)
+ return '%s: %s' % (self._
+ else:
+ return s
i.e.
if self._dbus_ error_name is None: dbus_error_ name, s)
return s
else:
return '%s: %s' % (self._