Search doesnt return any results

[Will Cooke]

PPA: 3.19.5+git20160204.867a153-0ubuntu1~ppa1

Searching for "frozen" (looking for Frozen Bubble, you know, for testing) returns no results.

From the logs it looks like Frozen Bubble was found though, but maybe the icon is missing:

(gnome-software:4989): GsPlugin-WARNING **: vbaexpress 7 2 4 2 4 / 19 -> 53
(gnome-software:4989): GsPlugin-DEBUG: ubuntu-reviews setting rating on vbaexpress to 53%
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::apt(gs_plugin_add_search;gs_plugin_refine)
APT: gs_plugin_refine
(gnome-software:4989): Gs-DEBUG: search cancelled
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::appstream(gs_plugin_add_search)
(gnome-software:4989): As-DEBUG: run 0x2012990~appstream::search
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::ubuntu-reviews(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::apt(gs_plugin_add_search;gs_plugin_refine)
APT: gs_plugin_refine
(gnome-software:4989): Gs-DEBUG: search cancelled
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::appstream(gs_plugin_add_search)
(gnome-software:4989): As-DEBUG: run 0x20129e0~appstream::search
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::ubuntu-reviews(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::apt(gs_plugin_add_search;gs_plugin_refine)
APT: gs_plugin_refine
(gnome-software:4989): Gs-DEBUG: search cancelled
(gnome-software:4989): Gs-DEBUG: search cancelled
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::appstream(gs_plugin_add_search)
(gnome-software:4989): As-DEBUG: run 0x2007b20~appstream::search
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::ubuntu-reviews(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::apt(gs_plugin_add_search;gs_plugin_refine)
APT: gs_plugin_refine
gespeaker.desktop update 0.8.6-1
qsampler.desktop update 0.3.1-1
frozen-bubble.desktop update 2.212-7build1
kmldonkey.desktop update 4:2.0.5+kde4.3.3-0ubuntu1
org.kde.cantor.desktop update 4:15.08.2-0ubuntu4
texstudio.desktop update 2.10.6+debian-1
ganyremote.desktop update 6.3.3-1
efax-gtk.desktop update 3.2.8-2ubuntu1
cen64-qt.desktop update 20150915-alpha-2
unity-tweak-tool.desktop update 0.0.6ubuntu3
cmst.desktop update 2016.01.28-2
mcrl2-gui.desktop update 201409.0-1ubuntu1
pypar2.desktop update 1.4-7
redshift-gtk.desktop update 1.10-5ubuntu1
GameConqueror.desktop update 0.13-1
YAGF.desktop update 0.9.3.2-1ubuntu1
gigolo.desktop update 0.4.2-1
freedink-dfarc.desktop update 3.12-1build1
smplayer.desktop update 15.11.0~ds0-1
gnome-mpv.desktop update 0.6-1
wammu.desktop update 0.40-1
xarchiver.desktop update 1:0.5.4-2
lyx.desktop update 2.1.4-2
fgo.desktop update 1.5.5-2
kanyremote.desktop update 6.3.5-1
vbaexpress.desktop update 1.2-0ubuntu5
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::epiphany(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::appstream(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x1b04b70~appstream::refine
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::hardcoded-blacklist(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x1b04b70~hardcoded-blacklist
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::icons(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::moduleset(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x1b04b70~GsPlugin::menu-spec-refine(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf vbaexpress.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf kanyremote.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf fgo.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf lyx.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf xarchiver.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf wammu.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf gnome-mpv.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf smplayer.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf freedink-dfarc.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf gigolo.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf YAGF.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf GameConqueror.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf redshift-gtk.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf pypar2.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf mcrl2-gui.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf cmst.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf unity-tweak-tool.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf cen64-qt.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf efax-gtk.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf ganyremote.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf texstudio.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf org.kde.cantor.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf kmldonkey.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf frozen-bubble.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf qsampler.desktop
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf gespeaker.desktop
frozen-bubble.desktop update 2.212-7build1
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::epiphany(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::appstream(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2012990~appstream::refine
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::hardcoded-blacklist(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2012990~hardcoded-blacklist
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::icons(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::moduleset(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2012990~GsPlugin::menu-spec-refine(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf frozen-bubble.desktop
frozen-bubble.desktop update 2.212-7build1
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::epiphany(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::appstream(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x20129e0~appstream::refine
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::hardcoded-blacklist(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x20129e0~hardcoded-blacklist
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::icons(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::moduleset(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x20129e0~GsPlugin::menu-spec-refine(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf frozen-bubble.desktop
frozen-bubble.desktop update 2.212-7build1
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::epiphany(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::appstream(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2007b20~appstream::refine
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::hardcoded-blacklist(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2007b20~hardcoded-blacklist
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::icons(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::moduleset(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): As-DEBUG: run 0x2007b20~GsPlugin::menu-spec-refine(gs_plugin_add_search;gs_plugin_refine)
(gnome-software:4989): Gs-DEBUG: app invalid as no pixbuf frozen-bubble.desktop
(gnome-software:4989): Gs-DEBUG: no search results to show
(gnome-software:4989): Gs-DEBUG: First hourly updates check

[Matthias Klumpp (ximion)]

I can confirm this bug.
The pixmap in question is present with the correct name in /var/lib/app-info/icons/ubuntu-xenial-universe/64x64/, so this app should be shown in GNOME Software.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Mateusz Stachowski (stachowski-mateusz)]

Search does return results for me but it only finds the programs that I already installed.

[Robert Ancell (robert-ancell)]

Hmm, shows Frozen-Bubble for me when I search for frozen.

Though I know you were really looking for the Disney princess movie.

[Iain Lane (laney)]

For me using appstream from the archive which is now in place:

  - appstreamcli search robocode works
  - The referenced icon exists (/var/lib/app-info/icons/ubuntu-xenial-universe/64x64/robocode_robocode.png)
  - "app invalid as no pixbuf" from gnome-software --verbose

[Iain Lane (laney)]

I did some poking, and it looks like the problem is that no icons are coming back from appstream-glib when it makes a store.

The path that it looks in for uninstalled applications when parsing YAML files (our case) was wrong - see the attached patch.

ximion, are you watching? Is this sane?

[Matthias Klumpp (ximion)]

I wonder why that happens - appstream-glib should look in /var/{lib|cache}/app-info/icons and /usr/share/app-info/icons for icons, so maybe adding the same logic used for the XML to the YAML part in appstream-glib makes sense.

[Iain Lane (laney)]

In as_store_from_root() (used for XML files), it does

      /* guess the icon path after we've read the origin and then look for
       * ../icons/$origin if the topdir is 'xmls', falling back to ./icons */
      if (icon_prefix != NULL) {
          g_debug ("icon_prefix: %s", icon_prefix);
          g_autofree gchar *topdir = NULL;
          topdir = g_path_get_basename (icon_prefix);
          if (g_strcmp0 (topdir, "xmls") == 0 && priv->origin != NULL) {
              g_autofree gchar *dirname = NULL;
              dirname = g_path_get_dirname (icon_prefix);
              icon_path = g_build_filename (dirname,
                                "icons",
                                priv->origin,
                                NULL);
          } else {
              icon_path = g_build_filename (icon_prefix, "icons", NULL);
          }
      }

Where icon_prefix is the directory the XML file was found in. We could do the same thing I suppose - our icons are in ../icons/ relative to the .yml.gz - but is it worth it?

BTW I just tried and this seems broken on Debian too - can you confirm that? Do you know what changed to make this happen?

[Iain Lane (laney)]

https://github.com/hughsie/appstream-glib/pull/92

[Launchpad Janitor (janitor)]

This bug was fixed in the package appstream-glib - 0.5.8-1ubuntu5

---------------
appstream-glib (0.5.8-1ubuntu5) xenial; urgency=medium

  * d/p/0001-Look-in-the-correct-icon-directory-for-yaml-files.patch Take a
    patch from upstream to look for icons in the directory that appstream
    unpacks them to. (LP: #1542242)

 -- Iain Lane <email address hidden> Mon, 15 Feb 2016 12:25:11 +0000