Comment 1 for bug 1416617

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

* debian/copyright isn't fully correct, it contains quite some copyright that are not listed:
libappstream-glib/as-utils.c: LGPL (v2.1 or later)
  [Copyright: 2014 Richard Hughes <email address hidden> / 2011 Paolo Bacchilega <email address hidden>]
libappstream-glib/as-cleanup.h: LGPL (v2.1 or later)
  [Copyright: 2014 Richard Hughes <email address hidden> / 2012 Colin Walters <email address hidden>]
libappstream-builder/asb-package-alpm.c: LGPL (v2.1 or later)
  [Copyright: 2014 Fabien Bourigault <email address hidden>]

And more… please check the copyrights again, and maybe propose some patches to debian?

* I guess until the ubuntu desktop team switch to an application requiring appstream-glib, you should get someone from the gnome ubuntu team to subscribe to bug reports.

* debian/rules:
override_dh_auto_test:
    # Don't run tests, they are always failing at time (20140924)
-> can you try to reenable them, and check if they are passing now? Maybe check with the debian maintainer and upstream about them? If theuy need to run as autopackage tests, maybe we can ship them as such?

* debian/control:
- the package build-dep against libqt4-dev. Why such? It seems nowhere there is any qt4 mention in the code. Some are qt3, but it's just when analyzing any application on the builder (which isn't shipped by default). Can we get away of that dep if it's not used at all?
- Would be nice to get that one fixed/reported upstream:
W: appstream-glib-doc: extended-description-line-too-long

Otherwise, the code looks good!