[PATCH] Add dmi and os information to apport collected, alsa-base bugs

[Brad Figg]

Binary package hint: apport

The attached patch:

   - Refactored out the dmi collection code from attach_hardware so it could
     be used in attach_alsa as well.
   - Added attach_dmi to attach_hardware.
   - Added attach_dmi to attach_alsa. I want to have the system information
     for statistics gathering.
   - Added call to add_os_info to attach_alsa to easily get the distro release
     version.

This is done so alsa-base bugs have dmi and os information added to the
other collected information.

ProblemType: Bug
ApportLog:
 apport (pid 2468) Tue Mar 30 10:29:15 2010: called for pid 2417, signal 11
 apport (pid 2468) Tue Mar 30 10:29:15 2010: executable: /usr/lib/nspluginwrapper/i386/linux/npviewer.bin (command line "/usr/lib/nspluginwrapper/i386/linux/npviewer.bin --plugin /usr/lib/flashplugin-installer/libflashplayer.so --connection /org/wrapper/NSPlugins/libflashplayer.so/2367-1")
 apport (pid 2468) Tue Mar 30 10:29:15 2010: apport: report /var/crash/_usr_lib_nspluginwrapper_i386_linux_npviewer.bin.1000.crash already exists and unseen, doing nothing to avoid disk usage DoS
Architecture: amd64
CheckboxSubmission: 3ef8587ee740ff623db7f67f58907ba0
CheckboxSystem: d00f84de8a555815fa1c4660280da308
CrashReports: 600:1000:1000:2015595:2010-03-23 10:46:29.844074634 -0700:2010-03-23 10:46:27.045360218 -0700:/var/crash/_usr_lib_nspluginwrapper_i386_linux_npviewer.bin.1000.crash
Date: Tue Mar 30 15:23:50 2010
DistroRelease: Ubuntu 10.04
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Alpha amd64 (20100203.1)
Package: apport 1.13.1-0ubuntu1
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-17.26-generic 2.6.32.10+drm33.1
SourcePackage: apport
Uname: Linux 2.6.32-17-generic x86_64

[Brad Figg (brad-figg)]

The changes are also available at: lp:~brad-figg/apport/ubuntu

[Martin Pitt (pitti)]

> - Added call to add_os_info to attach_alsa to easily get the distro release version.

This part is not necessary, since Apport calls it by default. The rest looks fine, thanks!

Committed into trunk r1756.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 1.13.2-0ubuntu1

---------------
apport (1.13.2-0ubuntu1) lucid; urgency=low

  [ Martin Pitt ]
  * New upstream bug fix release:
    - packaging-apt-dpkg.py, _install_debug_kernel(): Do not crash on an
      outdated kernel, just return that it is outdated. (LP: #532923)
    - launchpad.py test suite: Add "Referer" HTTP header, now required by
      launchpad.
    - launchpad.py: Fix crash if configuration does not have an
      "escalated_tag" option.
    - launchpad.py: Port to launchpadlib 1.0 API, thanks Michael Bienia for
      the initial patch! (LP: #545009)
    - gtk/apport-gtk-mime.desktop.in, kde/apport-kde-mime.desktop.in: Change
      categories so that these do not ever appear in menu editors.
      (LP: #449215)
    - launchpad.py: Some LP bugs have broken attachments (this is a bug in
      Launchpad itself). Ignore those instead of crashing.
    - apport-gtk: Turn http:// and https:// links into clickable hyperlinks in
      information and error dialogs. (LP: #516323)
    - apport-retrace: Fix crash when trying to rebuild package info for
      reports without an ExecutablePath. (LP: #436157)
    - ui.py: Fix crash when package information cannot be determined due to
      broken apt status. (LP: #362743)
    - ui.py: Fix crash when /etc/apport/crashdb.conf is damaged; print an
      appropriate error message instead. (LP: #528327)
    - data/kernel_crashdump: Fix crash if log file disappeared underneath us.
      (LP: #510327)
    - data/apport: Fix IOError when apport is called with invalid number of
      arguments, and stderr is not a valid fd. (LP: #467363)
    - hookutils.py: Factor out the DMI collection code from attach_hardware()
      into attach_dmi(), and call that in attach_alsa() as well. Thanks to
      Brad Figg for the patch! (LP: #552091)
    - apport/ui.py: Fix the help output if Apport is invoked under an
      alternative name (like apport-collect). (LP: #539427)
  * debian/local/apport-chroot: Fix crash if $APPORT_CRASHDB_CONF is not set.
    (LP: #487700)
  * debian/control: Bump python-launchpadlib dependency, to ensure that we
    have a current version (LP: #407091), and the "1.0" protocol available.
  * data/package-hooks/source_linux.py: Drop _() i18n, it's not available in
    the hook and causes crashes. (LP: #538368)

  [ Leann Ogasawara ]
  * data/package-hooks/source_linux.py:
    - Clean up some of the wording in the information dialogs for the
      interactive kernel hook. Also add an additional "I don't know" option when
      asked how frequently an issue occurs. (LP: #534638)
    - Autodetect if running an upstream kernel. (LP: #532932)
    - Attempt to categorize issue. Then add tag based on category.
      (LP: #534745)
 -- Martin Pitt <email address hidden> Wed, 31 Mar 2010 16:32:39 +0200