[PATCH] Autodetect if running an upstream kernel

[Leann Ogasawara]

Binary package hint: apport

After some discussion on the Ubuntu kernel-team mailing list regarding the apport kernel hook, there was feedback that asking a bug reporter if they'd tested with the upstream kernel was slightly confusing and not ideal. For example, if apport detected a kernel oops and prompted the user to file the bug, the reporter won't know how to properly answer if this has been tested/confirmed with the upstream kernel at this point in time as they haven't been given any information as to the actual contents of the oops until later in the reporting process. It was suggested that auto detecting if the reporter is currently running an upstream kernel would be best, otherwise just provide an informational dialog asking them to test the upstream kernel later on and post their results as a comment in the bug.

The patch attached does the following:

1) Auto detect if the reporter is currently running an upstream kernel. If so, instruct them to report the issue upstream.
2) Move the check for running a non-Ubuntu kernel to earlier in the hook. Otherwise we force the reporter to go through a series of questions and answers only to be told they can not file the bug as it's not an official Ubuntu kernel.
3) Replace the yes/no ui question of "has this been tested upstream?" to just an informational dialog requesting they test the upstream kernel and post their results to the bug.

ProblemType: Bug
ApportLog:
 apport (pid 9287) Fri Mar 5 11:42:19 2010: called for pid 2645, signal 6
 apport (pid 9287) Fri Mar 5 11:42:19 2010: executable: /usr/bin/synergyc (command line "synergyc yoji")
 apport (pid 9287) Fri Mar 5 11:42:20 2010: wrote report /var/crash/_usr_bin_synergyc.1000.crash
Architecture: i386
CheckboxSubmission: 27199aa7e30bbcb25cde0f30adca2f2c
CheckboxSystem: 8baff8f3b5cdd90914588b077dfd5f83
Date: Fri Mar 5 12:41:31 2010
DistroRelease: Ubuntu 10.04
Package: apport 1.12.1-0ubuntu4 [modified: usr/share/apport/package-hooks/source_linux.py]
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-15.22-generic
SourcePackage: apport
Uname: Linux 2.6.32-15-generic i686

[Leann Ogasawara (leannogasawara)]

I've also pushed this to a branch:

https://code.edge.launchpad.net/~leannogasawara/ubuntu/lucid/apport/ubuntu

http://bazaar.launchpad.net/~leannogasawara/ubuntu/lucid/apport/ubuntu/revision/1638

[Leann Ogasawara (leannogasawara)]

Actually revision is:

http://bazaar.launchpad.net/~leannogasawara/ubuntu/lucid/apport/ubuntu/revision/1640

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 1.13.2-0ubuntu1

---------------
apport (1.13.2-0ubuntu1) lucid; urgency=low

  [ Martin Pitt ]
  * New upstream bug fix release:
    - packaging-apt-dpkg.py, _install_debug_kernel(): Do not crash on an
      outdated kernel, just return that it is outdated. (LP: #532923)
    - launchpad.py test suite: Add "Referer" HTTP header, now required by
      launchpad.
    - launchpad.py: Fix crash if configuration does not have an
      "escalated_tag" option.
    - launchpad.py: Port to launchpadlib 1.0 API, thanks Michael Bienia for
      the initial patch! (LP: #545009)
    - gtk/apport-gtk-mime.desktop.in, kde/apport-kde-mime.desktop.in: Change
      categories so that these do not ever appear in menu editors.
      (LP: #449215)
    - launchpad.py: Some LP bugs have broken attachments (this is a bug in
      Launchpad itself). Ignore those instead of crashing.
    - apport-gtk: Turn http:// and https:// links into clickable hyperlinks in
      information and error dialogs. (LP: #516323)
    - apport-retrace: Fix crash when trying to rebuild package info for
      reports without an ExecutablePath. (LP: #436157)
    - ui.py: Fix crash when package information cannot be determined due to
      broken apt status. (LP: #362743)
    - ui.py: Fix crash when /etc/apport/crashdb.conf is damaged; print an
      appropriate error message instead. (LP: #528327)
    - data/kernel_crashdump: Fix crash if log file disappeared underneath us.
      (LP: #510327)
    - data/apport: Fix IOError when apport is called with invalid number of
      arguments, and stderr is not a valid fd. (LP: #467363)
    - hookutils.py: Factor out the DMI collection code from attach_hardware()
      into attach_dmi(), and call that in attach_alsa() as well. Thanks to
      Brad Figg for the patch! (LP: #552091)
    - apport/ui.py: Fix the help output if Apport is invoked under an
      alternative name (like apport-collect). (LP: #539427)
  * debian/local/apport-chroot: Fix crash if $APPORT_CRASHDB_CONF is not set.
    (LP: #487700)
  * debian/control: Bump python-launchpadlib dependency, to ensure that we
    have a current version (LP: #407091), and the "1.0" protocol available.
  * data/package-hooks/source_linux.py: Drop _() i18n, it's not available in
    the hook and causes crashes. (LP: #538368)

  [ Leann Ogasawara ]
  * data/package-hooks/source_linux.py:
    - Clean up some of the wording in the information dialogs for the
      interactive kernel hook. Also add an additional "I don't know" option when
      asked how frequently an issue occurs. (LP: #534638)
    - Autodetect if running an upstream kernel. (LP: #532932)
    - Attempt to categorize issue. Then add tag based on category.
      (LP: #534745)
 -- Martin Pitt <email address hidden> Wed, 31 Mar 2010 16:32:39 +0200