Comment 3 for bug 1851806

Revision history for this message
Benjamin Curtiss (bencurtiss6458) wrote :

I'm not exactly sure how to reproduce this bug, but I did encounter the same issue. It looks like the bug was recently introduced in this commit: https://git.launchpad.net/ubuntu/+source/apport/commit/?h=applied/ubuntu/xenial-security&id=ecd7418b02911c6649b69a592cca74cfbac8813d

```
@@ -510,22 +510,24 @@ class Report(problem_report.ProblemReport):
         - _LogindSession: logind cgroup path, if present (Used for filtering
           out crashes that happened in a session that is not running any more)
         '''
- if not pid:
- pid = self.pid or os.getpid()
- if not self.pid:
- self.pid = int(pid)
- pid = str(pid)
+ if not proc_pid_fd:
+ if not pid:
+ pid = self.pid or os.getpid()
+ if not self.pid:
+ self.pid = int(pid)
+ pid = str(pid)
+ proc_pid_fd = os.open('/proc/%s' % pid, os.O_RDONLY | os.O_PATH | os.O_DIRECTORY)

         try:
- self['ProcCwd'] = os.readlink('/proc/' + pid + '/cwd')
+ self['ProcCwd'] = os.readlink('cwd', dir_fd=proc_pid_fd)
         except OSError:
             pass
         self.add_proc_environ(pid, extraenv)
- self['ProcStatus'] = _read_file('/proc/' + pid + '/status')
- self['ProcCmdline'] = _read_file('/proc/' + pid + '/cmdline').rstrip('\0')
- self['ProcMaps'] = _read_maps(int(pid))
+ self['ProcStatus'] = _read_file('status', dir_fd=proc_pid_fd)
+ self['ProcCmdline'] = _read_file('cmdline', dir_fd=proc_pid_fd).rstrip('\0')
+ self['ProcMaps'] = _read_maps(proc_pid_fd)
         try:
- self['ExecutablePath'] = os.readlink('/proc/' + pid + '/exe')
+ self['ExecutablePath'] = os.readlink('exe', dir_fd=proc_pid_fd)
         except OSError as e:
             if e.errno == errno.ENOENT:
                 raise ValueError('invalid process')
```

The problem is that os.O_PATH does not exist in python2, and only exists in python3. However, python-apport is a python2 package.

```
bcurtiss@bcurtiss-laptop:~$ python3 -c 'import os; print(os.O_PATH)'
2097152
bcurtiss@bcurtiss-laptop:~$ python -c 'import os; print(os.O_PATH)'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: 'module' object has no attribute 'O_PATH'
bcurtiss@bcurtiss-laptop:~$
```