Ubuntu
apport package

  1. Bug #1492570
  2. Comment #17

Comment 17 for bug 1492570

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Patches look good, my only comment would be:

> for dmesg_file in glob.glob(os.path.join(apport.fileutils.report_dir, '*', 'dmesg.*')):

would traverse a symlink, for example:

/var/crash/012345678901 > /root

This doesn't matter when symlink restrictions are on.
When symlink restrictions are disabled, the impact is minor because the glob only looks for dmesg.* files.

I'm not sure if it is worth fixing because of the specific filename. Thoughts?