Comment 5 for bug 1661766

Revision history for this message
Christian Boltz (cboltz) wrote :

It seems to be an intentional regression :-(

I just found out that python has a "-Wall" option, so let's try it with python 3.5:

# python3 -Wall -c 'import re; re.search("hi", "hi", re.LOCALE)'
-c:1: DeprecationWarning: LOCALE flag with a str pattern is deprecated. Will be an error in 3.6

Argh. Now the python developers introduce backward-incompatible changes even in minor releases :-(

https://docs.python.org/3/library/re.html says
Changed in version 3.6: re.LOCALE can be used only with bytes patterns and is not compatible with re.ASCII.

On the positive side, it seems we only use re.LOCALE at two places in ui.py to get the (H)otkey from a text. I'll send a patch to remove the LOCALE flag and hope that this doesn't break anything ;-)