amule doesn't use the Download folder for incoming files

[shankao]

Binary package hint: amule

Since Ubuntu Karmic, it's created a "Download" folder in the user's home. To add consistency, amule should use it for incoming files.

ProblemType: Bug
Architecture: i386
Date: Sat Nov 21 13:18:25 2009
DistroRelease: Ubuntu 9.10
ExecutablePath: /usr/bin/amule
Package: amule 2.2.6-0ubuntu1
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-15.50-generic
SourcePackage: amule
Uname: Linux 2.6.31-15-generic i686
XsessionErrors:
 (gnome-settings-daemon:2475): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (nautilus:2508): Eel-CRITICAL **: eel_preferences_get_boolean: assertion `preferences_is_initialized ()' failed
 (polkit-gnome-authentication-agent-1:2526): GLib-CRITICAL **: g_once_init_leave: assertion `initialization_value != 0' failed
 (gnome-panel:2507): Gdk-WARNING **: /build/buildd/gtk+2.0-2.18.3/gdk/x11/gdkdrawable-x11.c:952 drawable is not a pixmap or window

[shankao (shankao)]

Hi, what is the progress on this bug?

[David Futcher (bobbo)]

Sorry, not found the time to work on this. Anyone else feel free to take it.

[Alessandro Losavio (alo21)]

Sorry, but seems that the code should be reviewed to fit with gcc 4.7. Unluckily I can not manage it

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Martin Pitt (pitti)]

I'm afraid this is not the right approach, as it doesn't take into account the user configuration nor works in non-English languages where the folder is translated. Please see http://freedesktop.org/wiki/Software/xdg-user-dirs for how to determine the directory; if your program uses GLib, you can also use the more convenient

  http://developer.gnome.org/glib/2.30/glib-Miscellaneous-Utility-Functions.html#g-get-user-special-dir

If you have a patch, can you please forward this to upstream first? Thanks!

[Martin Pitt (pitti)]

Unsubscribing sponsors, please resubscribe if/when there is a new patch.

[Dominique Ramaekers (dominique-ramaekers)]

I intent to work on this bug. I'm new en found this bug in Harvest. This bug is not verry active, so I think I have the time I to investigate how to manage bugs, deb-packages, patches...
I've checked with a fresh installation of amule on a Saucy installation, it stores music in ~/.aMule/incomming

In perspective of accasibility, I agree with this bug report. A normal user wouldn't look for his downloads in a hidden folder.

But the folder Downloads isn't logical neighter. Your aMule downloads will be mixed with the normal downloads (ex firefox)...

Who should I ask to help me pick the right folder? (I think 'Music' makes more sense but a seperate visible folder 'aMule' would to)

For now I didn't got a answer from the aMule community, but will it be ok just to make a Ubuntu patch without implementing the patch upstream (should they choos to keep the current folder)?

[shankao (shankao)]

Hi Dadio, nice to have you working in the bug, thanks!

The common folders in a default Ubuntu installation follow the XDG common folders specification. This allows apps to behave consistently and have different folder names depending on the user's locale.

So, the advised "Downloads" folder should be that returned by the "xdg-user-dir DOWNLOAD" command.
In a program that uses glib you can also use the function g_get_user_special_dir (https://developer.gnome.org/glib/stable/glib-Miscellaneous-Utility-Functions.html#g-get-user-special-dir)

[shankao (shankao)]

Well, that's basically what Martin wrote in the prev. comment. My fault.

[Dominique Ramaekers (dominique-ramaekers)]

I read it and I understand it. But Download isn't a good choice. The aMule will share all of your files in the Downloads folder. I wouldn't want that and I think most of the users wouldn't neither...

I also posted a bug report on the forum of aMule: http://amule.forumer.com/ubuntu-bug-486255-download-folder-not-in-amule-t2343824.html#p20695894

Apparently the folder was already changed for Windows and Mac but not for Linux. I'll do a follow-up of my bug-report on the aMule forum. I think that they'll change the folder from ~/.aMule/Incomming to ~/aMule Downloads like on Windows and Mac.

So I want to propose that in the linux code, the folder will be named "~/aMule [xdg-user-dit DOWLOAD]".

Acceptable?

[Dominique Ramaekers (dominique-ramaekers)]

I also mailed <email address hidden>. Sandro Tosi <email address hidden> responded that this bug is also in the debian bug tracking system: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=409068

They have forwarded the bug to the aMule.org years ago but until today, there is no follow-up on the bug...

I still want to change the folder. Will the patch be implemented - even maybe only in the Ubuntu repository - if I change the default folder to ~/aMule? This way, there is a hidden '~/.aMule' for the settings and partial downloads and there is a visible ~/aMule witch contains all the shared files.