Comment 642 for bug 1958019

Revision history for this message
In , donglingluoying (donglingluoying-linux-kernel-bugs) wrote :

Yeah, both the speaker and headphones work fine with correct channel.

And still work after resuming from suspend/hibernate.

Also fine after hotplug events, whatever it is playing or not.

Thanks for your patch a lot!

(In reply to Cameron Berkenpas from comment #627)
> Great!
>
> Some probably silly questions:
> 1) Do both speakers work? Do you get left channel sound out of the left
> speaker and right channel sound out of the right speaker?
>
> 2) After resuming from suspend/hibernate, does your sound still work?
>
> 3) What if you insert headphones and remove them? Does sound still work?
> Try removing the headphones both while sound is not playing and while
> it's not.
>
> Given that this old quirk works for your laptop, I think all of the
> above will be fine and I can work toward getting  this submitted.
>
>
> On 6/3/2022 5:34 PM, <email address hidden> wrote:
> > https://bugzilla.kernel.org/show_bug.cgi?id=208555
> >
> > --- Comment #626 from Songine (<email address hidden>) ---
> > (In reply to Cameron Berkenpas from comment #625)
> >> Did you test this yourself?
> >>
> >> On 6/3/22 00:11, <email address hidden> wrote:
> >>> https://bugzilla.kernel.org/show_bug.cgi?id=208555
> >>>
> >>> Songine (<email address hidden>) changed:
> >>>
> >>> What |Removed |Added
> >>>
> >>
> ----------------------------------------------------------------------------
> >>> CC|
> >>> |<email address hidden>
> >>>
> >>> --- Comment #624 from Songine (<email address hidden>) ---
> >>> (In reply to Cameron Berkenpas from comment #429)
> >>>> Created attachment 298789 [details]
> >>>> linux-legion-sound-0.0.13.patch
> >>>>
> >>>> auto mute is now properly disabled as per Takashi's suggestion.
> >>>>
> >>>> This patch is against the latest Linus tree, but applies against 5.14.3
> >> just
> >>>> fine.
> >>>>
> >>>> This patch includes the presumptive commit message and credit given to
> >>>> various people.
> >>>>
> >>>> Going through the Linux commit log, it seems full names and email
> >> addresses
> >>>> aren't needed, so I have a thank you list in the patch with the
> following:
> >>>> Andreas Holzer, Vincent Morel, sycxyc, Max Christian Pohle
> >>>>
> >>>> If you want to be mentioned (or if you know of someone who you think
> that
> >>>> should be included), please let me know!
> >>>>
> >>>> Here's a link to the patch submission:
> >>>>
> >>
> https://mailman.alsa-project.org/pipermail/alsa-devel/2021-September/189698.
> >>>> html
> >>> Hello, there is a device could use the patch, could you help me add it to
> >> the
> >>> patch file?
> >>>
> >>> SND_PCI_QUIRK(0x17aa, 0x3802, "Lenovo Yoga DuetITL 2021",
> >>> ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
> >>>
> > Yes, tested, and I am enjoging my speaker now.�[U+1F603]�
> >