Comment 455 for bug 1958019

Revision history for this message
In , dantahoua (dantahoua-linux-kernel-bugs) wrote :

(In reply to Takashi Iwai from comment #441)
> Both must be identical from the code perspective.
>
> But, looking at the verb sequence there, I doubt whether the 0xb020 call is
> really correct. If it follows the similar pattern as others, it should be
> rather setting the COEF index 0x26 instead, i.e.:
>
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8345,7 +8345,7 @@ static const struct hda_fixup alc269_fixups[] = {
> .v.verbs = (const struct hda_verb[]) {
> { 0x20, AC_VERB_SET_COEF_INDEX, 0x24 },
> { 0x20, AC_VERB_SET_PROC_COEF, 0x41 },
> - { 0x20, AC_VERB_SET_PROC_COEF, 0xb020 },
> + { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 },
> { 0x20, AC_VERB_SET_PROC_COEF, 0x2 },
> { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },
> { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },

That make sense! I translated this into simple verb to test on a config with no sound and it works.
Just compiled a new kernel with the update and it works also!

Thanks Takashi Iwai! Is this update will be be pushed to the next kernel?