Comment 375 for bug 1958019

Revision history for this message
In , cam (cam-linux-kernel-bugs) wrote :

What is the volume overshoot you're talking about? Probably missing the
verbs to set something up there.

Same goes for the HDMI probably... I hadn't thought to test even my
laptop against HDMI as I never use it and don't really have a convenient
way to test.

Not sure what the problem with the patches is... I tried all 3 in order
last night and they were fine.

On 7/13/21 10:16 AM, <email address hidden> wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=208555
>
> --- Comment #361 from <email address hidden> ---
> Just installed the latest patch for 13SGen2.
>
> Firstly, applying the patch linux-5.12-legion-sound-0.0.9-003.patch leads to
> some errors :
>
> patch -p1 < linux-5.12-legion-sound-0.0.9-003.patch
>
> patching file sound/pci/hda/patch_realtek.c
> Hunk #1 succeeded at 6352 with fuzz 2 (offset -6 lines).
> Hunk #2 FAILED at 6573.
> Hunk #3 succeeded at 8145 with fuzz 2 (offset -27 lines).
> Hunk #4 FAILED at 8558.
> 2 out of 4 hunks FAILED -- saving rejects to file
> sound/pci/hda/patch_realtek.c.rej
> patching file sound/pci/hda/thinkbook_13s_gen2_itl_coefs.c
>
> So I directly applied linux-5.12-legion-sound-0.0.9.patch and was able to
> compile and install with no error.
>
> The speaker sound is definitely better, the overshoot on the volume control
> is
> manageable.
> Its hard to compare to windows because of Dolby, but its close.
>
> The sound works after unplugging headphones (tried it multiple times).
> The headphone sound still has some cracking noise and the bug on the volume
> control reappears (at least from what I tested). The sound on headphone is
> still pretty good.
>
> I noticed a bug, rebooting the computer with an HDMI cable plugged in removes
> completely the sound card. This bug was also present in version 0.0.7 of the
> patch.
>