Comment 2 for bug 626797

Revision history for this message
Steve Langasek (vorlon) wrote : Re: Add wlan control for ASUS K-series laptops.

Thank you for taking the time to report this issue and help to improve Ubuntu.

Please submit patches in diff -u (unidiff) format.

This patch needs improvement on a couple of points. First, you don't want to trigger both /etc/acpi/events/asus-wireless-on and /etc/acpi/events/asus-wireless-off on the same event; this should be abstracted better, treating 0000005d as a "toggle" event. Second, /usr/share/acpi-support/state-funcs already supports the standard rfkill abstractions in the kernel, and if this doesn't work with the asus_laptop driver, that's a bug in that driver - not in acpi-support. Opening a task on this bug for the kernel side.