Comment 5 for bug 2008441
Revision history for this message
| Heitor Alves de Siqueira (halves) wrote | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Thank you for taking the time to fix this one, Tom!
The debdiff you submitted is quite big. If I'm understanding correctly, your intention was to submit a new upstream microrelease into the Ubuntu repos. While the SRU policy does foresee the case of a bugfix-only microrelease, I'm not fully confident that this is what we're dealing with here. Although I'm not an expert on the cockpit and 389-ds packages, there are a few things that do stand out from an initial review:
- there's additions of new rust depedencies (from the cargo.lock file)
- several requirements seem to have gone through version changes
- new vendor files being added (like "wasi", "winapi" and "unicode-xid")
- introduces new "acl" requirement in the spec file (this is explicitly called out a a no-go in the SRU Policy, as it'd introduce structural changes to the build system)
Furthermore, the upstream commit log between 2.0.15 and 2.0.16 [1] lists 44 commits, which is quite a bit for a microrelease. I'd really like us to double-check whether all 44 commits are needed for fixing this bug. Some of the commits don't seem related to the original issue (e.g. [2]).
It'd be great if we could either:
1) Provide /strong/ justification (and testing) in favor of pushing the 2.0.16 microrelease
2) Narrow down the (few?) responsible commits and backport only those to Jammy
Considering there's no SRU exception for this package, I'd expect significant resistance to the first option, unless we have significant motive as well :)
Ultimately, if the underlying problem is missing UI files, could this actually be a packaging or build-time bug? That won't have a corresponding upstream commit, and the original description mentioning index.html and manifest.json files does seem to hint at this (these don't seem to be in the 2.0.15..2.0.16 diff either).
[0] https:/
[1] https:/
[2] https:/