Comment 6 for bug 979914

Revision history for this message
Daniel Holbach (dholbach) wrote :

Here a quick review of things I found:

OPENERP-CORE
 - the version of the package should be <upstreamversion>-<debian/ubuntu revision>,
   it is only OK to have on '-' in the complete version string
 - '0' is not allowed as debian/ubuntu revision either, better make it '0ubuntu1' instead
 - debian/watch file links exclusively to 6.1-1 - it won't find a 6.1-2
 - the Section for the binary package is not necessary
 - minor: the patch in debian/patches might benefit from a description
   (http://dep.debian.net/deps/dep3/)
 - there's a file called .apidoc in /usr/openerp (not sure if that's intentional)
 - minor: these license files can be removed:
   usr/share/openerp/addons/base_tools/LICENSE
   usr/share/openerp/addons/web_calendar/static/lib/dhtmlxScheduler/license.txt
   usr/share/openerp/addons/web_graph/static/lib/dhtmlxGraph/codebase/thirdparty/excanvas/COPYING
   usr/share/openerp/addons/web_livechat/LICENSE
   usr/share/openerp/addons/web_uservoice/LICENSE
   (just make sure you integrate them in debian/copyright)
 - minor: these files can be removed:
   usr/share/openerp/addons/plugin_outlook/static/openerp-outlook-plugin/OpenERPOutlookPlugin.sln
   usr/share/openerp/addons/web/static/lib/py.parse/.hg_archival.txt
 - the following bits and pieces would be good to 1) remove, 2) depend on the package in the archive,
   3) symlink to the files in question if necessary:
   usr/share/openerp/addons/wiki/web/widgets/rss/feedparser.py
   usr/share/openerp/addons/web/static/lib/underscore/underscore.js
   usr/share/openerp/addons/web/static/lib/jquery.tipsy/jquery.tipsy.js
   usr/share/openerp/addons/web/static/lib/jquery.form/jquery.form.js
 - etc/init.d/openerp-core does not provide itself (none of the provided facilities
   match the name of the init script)
 - etc/init.d/openerp-core does not implement 'status'
 - usr/share/openerp/addons/plugin_thunderbird/static/thunderbird_plugin/chrome/openerp_plugin.jar
   contains no code

OPENERP-DESKTOP
 - desktop does not have a debian/watch file
 - http://open-object.debian-maintainers.org/ does not seem to exist
 - where does the source tarball come from?