Comment 10 for bug 783220

Revision history for this message
In , Aleksander Morgado (aleksander-m) wrote :

(In reply to Fabrice Bellet from comment #1)
> Created attachment 114525 [details] [review]
> mbm: add GPS location gathering support
>
> This patch add gps support for mbm devices, mainly inspired by the huawai
> similar plugin. The interval between two batches of NMEA sentences is set
> arbitrarily to 5 secs with a #define (ModemManager updates the gps location
> every 30 seconds on dbus, so it seems to me there's no need to request nmea
> data too frequently). The mbm device particularity is that the gps nmea
> device ttyACM2 must receive the command "AT*E2GPSNPD" before starting to
> emit data.

The ID_MM_ERICSSON_MBM_AT_PORT and ID_MM_ERICSSON_MBM_AT_PPP flags should not be added. MBM uses by default the "MMBroadbandBearerMbm" object, and that object requires the presence of the WWAN net port. i.e. MBM modems will always use a WWAN port and never PPP, at least when managed by ModemManager.

Could you update the patch so that only the GPS bits gets included?