Comment 14 for bug 441905

Revision history for this message
Chris Coulson (chrisccoulson) wrote : Re: [Karmic] strange behaivor by clicking buttons

Here's my full git bisect log:

git bisect start
# bad: [05ded28d7d282bed6de457edeeb3e1461ea0d0ac] Updated Japanese translation
git bisect bad 05ded28d7d282bed6de457edeeb3e1461ea0d0ac
# good: [b841251ca79c332fd9922973b2a40e1298ae7f47] 2.18.0
git bisect good b841251ca79c332fd9922973b2a40e1298ae7f47
# bad: [6fef640debbe468586ff866cbef38d7a29c452d1] Only select for button and pointer event on toplevels
git bisect bad 6fef640debbe468586ff866cbef38d7a29c452d1
# good: [06c208f8f1db10fc46ea44dc06fdd92b76467b4f] Updating Estonian translation
git bisect good 06c208f8f1db10fc46ea44dc06fdd92b76467b4f
# good: [f2d9f5a9e6d4d9d3de1510b39d9a0ce0a976a4b3] Remove unused variable
git bisect good f2d9f5a9e6d4d9d3de1510b39d9a0ce0a976a4b3
# bad: [e81501ebea4cceffce2890519807b0c243fec0a3] Sent button events don't cause passive grabs
git bisect bad e81501ebea4cceffce2890519807b0c243fec0a3
# bad: [5ebb32d1ffa23241d562fb4d5be02bc6f156b515] Extend _gdk_windowing_window_at_pointer to be able to get toplevels only
git bisect bad 5ebb32d1ffa23241d562fb4d5be02bc6f156b515
# good: [fe188a18f324f4545af857436a6060e676a1287d] Bug 596494 - New property "cursor" in 2.18's GdkWindow with wrong type?
git bisect good fe188a18f324f4545af857436a6060e676a1287d

And the bad commit:

5ebb32d1ffa23241d562fb4d5be02bc6f156b515 is first bad commit
commit 5ebb32d1ffa23241d562fb4d5be02bc6f156b515
Author: Alexander Larsson <email address hidden>
Date: Mon Sep 28 15:21:54 2009 +0200

    Extend _gdk_windowing_window_at_pointer to be able to get toplevels only

    This has two advantages:
    1) In many backends, this is faster as we can terminate the window
    hierarchy traversal earlier
    2) When used in gdkdisplay.c::get_current_toplevel() to get the
    current toplevel that has the pointer we now correctly return
    a toplevel with the pointer in it where the pointer is inside
    some foreign subwindow of a toplevel window.

    The second advantage fixes some bugs in client side event generation
    when the pointer is inside such a foreign child window.

:040000 040000 0bf878a4bdc90edc26e1fabca17810153eab556d 3b77b97a97805a1fe60cee79033e1a7fec10bdb6 M gdk