> Can you mention removal of the unused cliprect parameters to the TODO list
> please?
Added before moz_gtk_widget_paint().
>The old logic was different from what GetStateFlagsFromGtkWidgetState does,
>which makes me think that GetStateFlagsFromGtkWidgetState should set
>GTK_STATE_FLAG_PRELIGHT (when inHover) and GTK_STATE_FLAG_ACTIVE (when
>depressed or active) independently of each other.
Updated the GetStateFlagsFromGtkWidgetState(), it composes the flags now.
> In moz_gtk_gripper_paint:
> gtk_handle_box_paint also calls gtk_render_frame.
Yeah. gtk_handle_box_paint draws gtk_render_handle() differently,
regards to the handle_position. But the effective_handle_position() (from gtk_handle_box_paint) uses GtkHandleBoxPrivate which seems to be hidden/private.
Created attachment 595369
gtk drawing patch v.5
Thanks, there's an updated version. Some remarks:
> Can you mention removal of the unused cliprect parameters to the TODO list
> please?
Added before moz_gtk_ widget_ paint() .
>The old logic was different from what GetStateFlagsFr omGtkWidgetStat e does, omGtkWidgetStat e should set FLAG_PRELIGHT (when inHover) and GTK_STATE_ FLAG_ACTIVE (when
>which makes me think that GetStateFlagsFr
>GTK_STATE_
>depressed or active) independently of each other.
Updated the GetStateFlagsFr omGtkWidgetStat e(), it composes the flags now.
> In moz_gtk_ gripper_ paint: box_paint also calls gtk_render_frame.
> gtk_handle_
Yeah. gtk_handle_ box_paint draws gtk_render_handle() differently, handle_ position( ) (from gtk_handle_ box_paint) uses GtkHandleBoxPrivate which seems to be hidden/private.
regards to the handle_position. But the effective_