Comment on attachment 563817 mozcontainer.c patch, v2
>+#include <gdk/gdkx.h>
Surrounding the gdk_x11_* function definitions in gtk2compat.h with something like "#ifdef GDK_WINDOW_XDISPLAY" would make this include unnecessary.
>- widget->style = gtk_style_attach (widget->style, widget->window); >+ gtk_widget_style_attach(widget);
gtk_widget_style_attach is not needed in GTK3, so it may make sense to remove gtk_widget_style_attach from gtk2compat.h and make the gtk_style_attach line #ifdef MOZ_WIDGET_GTK2.
>- >- GTK_WIDGET_SET_FLAGS (widget, GTK_MAPPED); >+
>- >- GTK_WIDGET_SET_FLAGS(widget, GTK_REALIZED); >+
Unnecessary extra white space added in the blank lines.
>+ gtk_widget_set_window(widget, gdk_window_new (gtk_widget_get_parent_window (widget), >+ &attributes, attributes_mask));
Can you align &attributes with gtk_widget_get_parent_window, please?
Comment on attachment 563817
mozcontainer.c patch, v2
>+#include <gdk/gdkx.h>
Surrounding the gdk_x11_* function definitions in gtk2compat.h with XDISPLAY" would make this include
something like "#ifdef GDK_WINDOW_
unnecessary.
>- widget->style = gtk_style_attach (widget->style, widget->window); style_attach( widget) ;
>+ gtk_widget_
gtk_widget_ style_attach is not needed in GTK3, so it may make sense to remove style_attach from gtk2compat.h and make the gtk_style_attach line
gtk_widget_
#ifdef MOZ_WIDGET_GTK2.
>- SET_FLAGS (widget, GTK_MAPPED);
>- GTK_WIDGET_
>+
>- SET_FLAGS( widget, GTK_REALIZED);
>- GTK_WIDGET_
>+
Unnecessary extra white space added in the blank lines.
>+ gtk_widget_ set_window( widget, gdk_window_new (gtk_widget_ get_parent_ window (widget),
>+ &attributes, attributes_mask));
Can you align &attributes with gtk_widget_ get_parent_ window, please?