you just want to do ifdef MOZ_WIDGET_GTK2 here, I don't think we want this on OS/2 or beos, etc.
> // The implementation version is updated during development when we
> // want to change schema, or to recover from updating bugs. When an
> // implementation version change is detected, the database is scrapped
> // and we start over.
>-#define IMPLEMENTATION_VERSION 3
>+#define IMPLEMENTATION_VERSION 4
Comment on attachment 318863
increase the page size, let the cache size grow on linux
>+#ifdef XP_WIN "urlclassifier. updatecachemax" , -1); "urlclassifier. updatecachemax" , -1); "urlclassifier. updatecachemax" , 100 * 1024 * 1024);
>+pref(
>+#elifdef XP_MACOSX
>+pref(
>+#else
>+pref(
>+#endif
you just want to do ifdef MOZ_WIDGET_GTK2 here, I don't think we want this on OS/2 or beos, etc.
> // The implementation version is updated during development when we VERSION 3 VERSION 4
> // want to change schema, or to recover from updating bugs. When an
> // implementation version change is detected, the database is scrapped
> // and we start over.
>-#define IMPLEMENTATION_
>+#define IMPLEMENTATION_
as an aside, this is really bloody convenient. :)
>+ if (gUpdateCacheSize > 0) { ("PRAGMA cache_size="); .AppendInt( cachePages) ; >ExecuteSimpleS QL(cacheSizePra gma);
>+ PRUint32 cachePages = gUpdateCacheSize / PAGE_SIZE;
>+ nsCAutoString cacheSizePragma
>+ cacheSizePragma
>+ rv = mConnection-
>+ if (NS_FAILED(rv)) {
>+ mUpdateStatus = rv;
>+ return rv;
>+ }
>+ mGrewCache = PR_TRUE;
>+ }
>+ nsCAutoString cacheSizePragma ("PRAGMA page_size="); .AppendInt( PAGE_SIZE) ;
>+ cacheSizePragma
ITYM pageSizePragma
looks good, r=me