Hi Laider, I've had a look at the package and Andreas' concerns (and a few of mine) do need addressing first. Specifically:
* There's no need for copyright comments in d/control, d/copyright, or d/rules -- the "Files: debian/*" clause in d/copyright defines that Canonical has the copyright of all files in debian/
* Given the declared upstream repo (https://github.com/OP-TEE/optee_test) has release tags, it would certainly be to our advantage to have a d/watch file included. I'd suggest something like the following (allowing for the fact Launchpad is going to butcher the wrapping here):
* Technically, the version number ought to be ...-0ubuntu1 but I'm happy to adjust that sort of thing during sponsorship. A hint for working with PPAs: I generally find it's easiest to upload with the "correct" version number plus a ~ppa1 suffix which I can then bump with subsequent revisions; the "~" ensures it sorts before the final revision, so anything using the PPA will eventually upgrade implicitly to the archive revision. For example in this case I would've uploaded something like 3.18.0-0ubuntu1~ppa1 then revised to 3.18.0-0ubuntu1~ppa2 and so on. Eventually, 3.18.0-0ubuntu1 would be uploaded to the archive and that sorts after the PPA revisions
* Andreas is correct in noting that nemos-dev-key and nemos-dev-cert are needed first. For reference, LP: #2043448 is the needs-packaging bug for nemos-dev-key (which also produces nemos-dev-cert). That's been sponsored by @tsimonq2 already, but hasn't been accepted into the archive yet. I suspect it's worth waiting to see what the AAs say about nemos-dev-key before uploading this
Hi Laider, I've had a look at the package and Andreas' concerns (and a few of mine) do need addressing first. Specifically:
* There's no need for copyright comments in d/control, d/copyright, or d/rules -- the "Files: debian/*" clause in d/copyright defines that Canonical has the copyright of all files in debian/
* Given the declared upstream repo (https:/ /github. com/OP- TEE/optee_ test) has release tags, it would certainly be to our advantage to have a d/watch file included. I'd suggest something like the following (allowing for the fact Launchpad is going to butcher the wrapping here):
version=4
opts=\ gle=s/. +\/@ANY_ VERSION@ \.tar\. gz/@PACKAGE@ _$1.orig. tar.gz/ \ /github. com/OP- TEE/optee_ test/tags .*\/@ANY_ VERSION@ \.tar\. gz \
filenameman
https:/
debian
* Technically, the version number ought to be ...-0ubuntu1 but I'm happy to adjust that sort of thing during sponsorship. A hint for working with PPAs: I generally find it's easiest to upload with the "correct" version number plus a ~ppa1 suffix which I can then bump with subsequent revisions; the "~" ensures it sorts before the final revision, so anything using the PPA will eventually upgrade implicitly to the archive revision. For example in this case I would've uploaded something like 3.18.0- 0ubuntu1~ ppa1 then revised to 3.18.0- 0ubuntu1~ ppa2 and so on. Eventually, 3.18.0-0ubuntu1 would be uploaded to the archive and that sorts after the PPA revisions
* Andreas is correct in noting that nemos-dev-key and nemos-dev-cert are needed first. For reference, LP: #2043448 is the needs-packaging bug for nemos-dev-key (which also produces nemos-dev-cert). That's been sponsored by @tsimonq2 already, but hasn't been accepted into the archive yet. I suspect it's worth waiting to see what the AAs say about nemos-dev-key before uploading this