Comment 14 for bug 1971027

It looks like the most recent upstream submission of the TDX attestation driver has some changes that can potentially break user-space applications that are relying on this feature.

In particular:

 1) device renamed from /dev/tdx-guest to /dev/tdx_guest

 2) members inside struct tdx_report_req has been shuffled a bit to prevent holes

We can either move forward and apply the same changes, but 2 seems a bit dangerous, because it may break user-space in a bad way.

If doable, a better possibility would be to drop the TDX attestation driver support from the generic kernel, then merge the whole TDX support (both attestation driver and the lazy accept patch) in the Azure kernel for now (or the cloud kernels that are considering to start using this feature) and when things will settle generic will get the same changes from Azure (or any other cloud kernel with the TDX patches).

Opinions?