@mapreeri Thank you for the detailed feedback, I've addressed everything you've identified.
1) You're right, it's no longer required. Resolved.
2) Thanks. Resolved.
3) Yep, you're correct compat 10 does this by default. Resolved.
4) Thanks, you're right. Including /usr/share/dpkg/buildflags.mk is no longer a requirement. Resolved.
5) Thanks. See 6. Resolved.
6) I noticed vala-panel.1 is upstream so I removed it from the debain/ packaging. I added vala-panel-runner.1 to the debian/ packaging since it was missing and fixed it based on your feedback. I've also submitted vala-panel-runner.1 upstream - https://github.com/rilian-la-te/vala-panel/pull/69
7) Resolved.
8) Resolved.
9) Resolved.
10) Resolved.
11) Pull request submitted https://github.com/rilian-la-te/vala-panel/pull/69
12) Thanks. Resolved.
13) Thanks. Updated accordingly.
14) Thanks. Updated accordingly. I'll talk to upstream.
15) Thanks. Updated accordingly.
A .dsc (it has been updated) can be downloaded from ppa:flexiondotorg/needs-packaging using:
@mapreeri Thank you for the detailed feedback, I've addressed everything you've identified.
1) You're right, it's no longer required. Resolved. dpkg/buildflags .mk is no longer a requirement. Resolved. /github. com/rilian- la-te/vala- panel/pull/ 69 /github. com/rilian- la-te/vala- panel/pull/ 69
2) Thanks. Resolved.
3) Yep, you're correct compat 10 does this by default. Resolved.
4) Thanks, you're right. Including /usr/share/
5) Thanks. See 6. Resolved.
6) I noticed vala-panel.1 is upstream so I removed it from the debain/ packaging. I added vala-panel-runner.1 to the debian/ packaging since it was missing and fixed it based on your feedback. I've also submitted vala-panel-runner.1 upstream - https:/
7) Resolved.
8) Resolved.
9) Resolved.
10) Resolved.
11) Pull request submitted https:/
12) Thanks. Resolved.
13) Thanks. Updated accordingly.
14) Thanks. Updated accordingly. I'll talk to upstream.
15) Thanks. Updated accordingly.
A .dsc (it has been updated) can be downloaded from ppa:flexiondoto rg/needs- packaging using:
dget -u -x https:/ /launchpad. net/~flexiondot org/+archive/ ubuntu/ needs-packaging /+files/ vala-panel_ 0.3.65- 0ubuntu1. dsc