Comment 2 for bug 1699333

Revision history for this message
Mattia Rizzolo (mapreri) wrote :

1. Who's the person in Maintainer that doesn't seem to be you nor "ubuntu developers" as customary?
2. can debhelper compat level be the last?
3. same for Standards-Version?
4. Vcs-* fields point to the upstream repository instead of the packaging one
5. please rename debian/docs following the package name, it *does* cause a lot of confusion to people not used to it to discover that it's not installed where they would expect it…
6. in d/rules please move that --buildsystem option to the main dh options instead of repeating it everywhere
7. also in d/rules please consider removing those unused code commented out, and removing that $(DHFLAGS) that is used only one
8. why do you call dh_strip manually, in only few packages? is dh_strip doing it wrong by itself?
9. why isn't the library in an appropriately named libary package, as all library should be? Installing a library in an application package doesn't sound like a good idea at all; you also overrode a lintian tag about this without giving a single comment.
10. lintian also contains some suggestion that you should definitely follow; please run a full lintian (with pedantic enabled); I'm mostly referring to the tags related to the binaries descriptions
11. d/copyright doesn't have a paragraph for 'Files: *'; whilst in itself is not a problem lintian highlights how you are not covering the 'LICENSE' file itself; probably the first paragraph should be turned into 'Files: *'

Note that I didn't do a copyright check of the package.