Ubuntu

Bug #1178202
Comment #1

Comment 1 for bug 1178202

Revision history for this message

Andrew Starr-Bochicchio (andrewsomething) wrote on 2013-05-14:

Here goes a quick review,

1) I don't see any reason that this should be a native package. You'd be better off using '3.0 quilt' for the debian/source/format

2) debian/changelog:
- The upload target should be saucy
- The version should be 13.05.1-0ubuntu1

2) debian/control:
   - software-center is listed twice in the Depends
   - The Standards-Version should be 3.9.4
   - Maintainer should be Ubuntu Developers <email address hidden>
     (see https://wiki.ubuntu.com/DebianMaintainerField)
   - You should probably drop the XB fields related to extras.
   - You might want to expand the description a bit.

3) It would be nice to have a debian/watch file even though you're upstream. See:
http://developer.ubuntu.com/packaging/html/debian-dir-overview.html#the-watch-file

4) debian/copyright has a few minor issues:
   - You don't need to list "Copyright" multiple times in the same paragraph. (See example)
   - You should include a license snippet, not just a link to the common-licenses file. (See example)
   - See: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Files: *
Copyright: 1998 John Doe <email address hidden>
1998 Jane Smith <email address hidden>
License: GPL-2+
This program is free software; you can redistribute it
and/or modify it under the terms of the GNU General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later
version.
.
This program is distributed in the hope that it will be
useful, but WITHOUT ANY WARRANTY; without even the implied
warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE. See the GNU General Public License for more
details.
.
You should have received a copy of the GNU General Public
License along with this package; if not, write to the Free
Software Foundation, Inc., 51 Franklin St, Fifth Floor,
Boston, MA 02110-1301 USA
.
On Debian systems, the full text of the GNU General Public
License version 2 can be found in the file
`/usr/share/common-licenses/GPL-2'.

All in all, it's almost ready. It builds, installs, and runs great.

Here goes a quick review,

1) I don't see any reason that this should be a native package. You'd be better off using '3.0 quilt' for the debian/source/format

2) debian/changelog:
   - The upload target should be saucy
   - The version should be 13.05.1-0ubuntu1

2) debian/control:
   - software-center is listed twice in the Depends
   - The Standards-Version should be 3.9.4
   - Maintainer should be Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
     (see https://wiki.ubuntu.com/DebianMaintainerField)
   - You should probably drop the XB fields related to extras.
   - You might want to expand the description a bit.

3) It would be nice to have a debian/watch file even though you're upstream. See:
    http://developer.ubuntu.com/packaging/html/debian-dir-overview.html#the-watch-file

4) debian/copyright has a few minor issues:
   -  You don't need to list "Copyright" multiple times in the same paragraph. (See example)
   -  You should include a license snippet, not just a link to the common-licenses file. (See example)
   - See: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Files: *
Copyright:  1998 John Doe <jdoe@example.com>
                     1998 Jane Smith <jsmith@example.net>
License: GPL-2+
 This program is free software; you can redistribute it
 and/or modify it under the terms of the GNU General Public
 License as published by the Free Software Foundation; either
 version 2 of the License, or (at your option) any later
 version.
 .
 This program is distributed in the hope that it will be
 useful, but WITHOUT ANY WARRANTY; without even the implied
 warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
 PURPOSE.  See the GNU General Public License for more
 details.
 .
 You should have received a copy of the GNU General Public
 License along with this package; if not, write to the Free
 Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 Boston, MA  02110-1301 USA
 .
 On Debian systems, the full text of the GNU General Public
 License version 2 can be found in the file
 `/usr/share/common-licenses/GPL-2'.

All in all, it's almost ready. It builds, installs, and runs great.