Comment 1 for bug 112678

Revision history for this message
Rich Johnson (nixternal) wrote : Re: [need-packaging] Kradview

Upstream needs to fix a few things first. It would be nice if he could create a proper tar.gz file, but is not all that necessary. A big thing that needs to be fixed is his licensing. His copy file expresses GPL v3 or newer, which luckily we can work with now since his package links to KDE libs. However, his Copyright headers all have issues. Here is just a quick print out of the issues I found running 'licensecheck' on the source:
========================================
admin/bcheck.pl: *No copyright* UNKNOWN

admin/conf.change.pl: *No copyright* LGPL (v2 or later) (with incorrect FSF address)

admin/config.pl: *No copyright* LGPL (v2 or later) (with incorrect FSF address)

admin/cvs-clean.pl: UNKNOWN
  [Copyright: notice. There is NO WARRANTY of any kind]

admin/cvs.sh: *No copyright* UNKNOWN

admin/detect-autoconf.sh: *No copyright* UNKNOWN

admin/ltmain.sh: GPL (v2 or later) (with incorrect FSF address) GENERATED FILE
  [Copyright: 1996, 1997, 1998, 1999, 2000, 2001, 2003]

config.h: *No copyright* GENERATED FILE

src/Panel2DBase.cpp: *No copyright* GENERATED FILE

src/Panel2DBase.h: *No copyright* GENERATED FILE

src/TaglistBase.cpp: *No copyright* GENERATED FILE

src/TaglistBase.h: *No copyright* GENERATED FILE

src/dicomfformat.c: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/dicomfformat.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/dicomimage.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/dicomimage.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/dicomimageview.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/dicomimageview.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/kradview.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/kradview.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/kradview_client.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/kradviewiface.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/kradviewview.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/kradviewview.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/main.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/panel2d.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/panel2d.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/pref.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/pref.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/taglist.cpp: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]

src/taglist.h: GPL (v3 or later) (with incorrect FSF address)
  [Copyright: 2005 by David Santo Orcero *]
================================================

Definitely needs to update his headers and his copyright year. I don't see how it is possible to be Copyrighted in 2005, when the GPL isn't even a year old yet :) If you can, I would recommend you pass this on to the upstream developer. Thank you!