Comment 8 for bug 1913266

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2021-02-02 04:43 EDT-------
(In reply to comment #15)
> The first try for that would be to only adapt the new code in
> virDomainVsockDefCheckABIStability to use the "old style" call to
> virDomainVirtioOptionsCheckABIStability (19d4e46770).
> While that seems easy the bigger dependency is "virDomainCheckVirtioOptions"
> which without Michals series isn't available in src/conf/domain_validate.c
> And that in turn depends on c05f00666c for PostParse.
>
> For the 7.0 into Hirsute that isn't too much of a problem, but for the
> backports I'm slightly concerned. I didn't see an immediate problem - but it
> will have to be double checked as one would want to avoid regressions of the
> "yes I know it is wrong, but it used to work until your update" kind.
>
> But one step at a time, for Hirsute I've prepared a test build as part of
> the 7.0 builds at:
> https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4408/+packages
>
> Once (if) libvirt_7.0.0-1ubuntu1~ppa7 (or later) is built there I'd
> appreciate if IBM could do a check of that build on an secure execution
> enabled machine.

Christian,
the version I sent to the mailing list should work without Michals patches.
https://www.redhat.com/archives/libvir-list/2021-January/msg01149.html