[Browser] F11 should toggle app-level fullscreen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy |
Bug Description
Pressing F11 should toggle the application level fullscreen.
Note that this is different from page level fullscreen, which is triggered by the page itself.
We should research if we want to merge the two concepts so that for the user there is only one notion of fullscreen and only one way to exit fullscreen, regardless of how it was activated (F11 or page interaction).
Or if we want to have to have one way to escape app level fullscreen (e.g. F11) and one to escape page level fullscreen (e.g. ESC)
[Design Comment]
Agree with Bill Filler & Olivier Tilloy's first suggestion (i.e. concepts should be merged/ be consistent). It would appear they do not need to be mutually exclusive, so:
- If Page triggers fullscreen: Navigating back/away from page that triggered FS, Pressing f11 (toggle FS/ Windowed) or Pressing Esc (return to windowed from FS only) returns to windowed mode.
- If User triggers fullscreen: Navigation has no effect on FS/ Windowed modes, Pressing f11 (toggle FS/ Windowed) or Pressing Esc (return to windowed from FS only) returns to windowed mode.
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ugo Riboni: Pending requested
-
Diff: 334 lines (+176/-63)5 files modifiedsrc/app/BrowserWindow.qml (+10/-8)
src/app/ChromeController.qml (+22/-14)
src/app/webbrowser/Browser.qml (+4/-8)
src/app/webbrowser/webbrowser-app.qml (+19/-0)
tests/autopilot/webbrowser_app/tests/test_fullscreen.py (+121/-33)
Changed in webbrowser-app (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Olivier Tilloy (osomon) |
status: | Confirmed → In Progress |
Changed in ubuntu-ux: | |
assignee: | nobody → James Mulholland (jamesjosephmulholland) |
importance: | Undecided → Medium |
description: | updated |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
summary: |
- F11 should toggle app-level fullscreen + [Browser] F11 should toggle app-level fullscreen |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
we should merge the concepts I think so there is one notion of fullscreen regardless of how it's triggered