[browser] add support for keyboard shortcuts

[Bill Filler]

need to add commands similar to the other apps so it works well on the desktop:

- fullscreen mode and toggle (via function key)
- esc key to toggle out of fullscreen
- ctrl-l to display the url bar and select all text in it
- keyboard shortcuts for navigation (back, forward) - check what chrome/chromium/firefox does here
- keyboard shortcut for reload a page
- keyboard shortcut to display history
- others???

[Bill Filler (bfiller)]

some of these may apply to both webbrowser-app and webapp-container

[Adnane Belmadiaf (daker)]

Here are some keyboard shortcuts that can be implemented :
- Ctrl+t : Open tab
- Ctrl+w : Close tab
- Ctrl+tab : Navigate between tabs
- F6 : Open the toolbar + focus the adressebar

[Mark Rowan (mark-tamias)]

When editing in the GMail webapp, it's not possible to select text with the mouse, or to alter the current selection with Shift+Up (all other arrow key combinations work).

[Pat McGowan (pat-mcgowan)]

Ctrl + '+' and Ctrl + '- ' let users zoom in & out. Ctrl + '0' resets the zoom value to default

[Arthur Mello (artmello)]

The following keyboard shortcuts have been added tho this branch:
* Ctrl + L: Display the url bar
* Ctrl + T: Open new Tab
* Ctrl + W: Close current Tab
* Ctrl + Tab: Navigate between tabs
* Ctrl + R: Reload current Tab
* Ctrl + D: Bookmark current Tab
* Ctrl + H: Show History
* Shift + Backspace: Goes to the next page in history
* Alt + Left Arrow: Goes to the previous page in history
* Alt + Right Arrow: Goes to the next page in history
* F6: Display the url bar
* F11: Toggle window fullscreen
* Esc: Return from fullscreen

Those commands will only work if the focus is not at the WebView, will only work if focus is on the URL bar or on the Window itself. There is a bug on Oxide since it is not forwarding Keyboard events that are not being handled: https://bugs.launchpad.net/oxide/+bug/1313727

The commands for Zoom In and Zoom Out are not implemented yet because Oxide does not support this functionality yet.

[Mateusz Stachowski (stachowski-mateusz)]

You should add F5 for reloading current Tab it is used alongside Ctrl + R in all browsers and even file managers like Nautilus.

[Thibaut Brandscheid (k1au3-is-37)]

CTRL + SHIFT + T: reopen previously closed tab
ALT + 1-8: show first [tab number]
ALT + 9: show last tab

Plus one suggestion, for a new, unusual shortcut:
ALT + Enter: open settings

[Bartosz Kosiorek (gang65)]

It seems that some work was done. Maybe we should push it to trunk?

[Olivier Tilloy (osomon)]

That branch (that you submitted for review) was not ready. It was worked on a while ago but left unfinished due to changing priorities, and not updated since then. I’m afraid this will need more work before it’s ready to merge.

[Bartosz Kosiorek (gang65)]

@Oliver.

Thanks for response. Can I continue work on that part (keyboard shortcut support)?

[Olivier Tilloy (osomon)]

Of course Bartosz, if you can get it into a usable state that will be very welcome!

[Bartosz Kosiorek (gang65)]

I have added most needed shortcuts:
* Ctrl + L: Select the content in the address bar
* Ctrl + T: Open new Tab
* Ctrl + W: Close current Tab
* Ctrl + Tab: Navigate between tabs
* Ctrl + R: Reload current Tab
* Ctrl + D: Bookmark current Tab
* Ctrl + H: Show History
* Shift + Backspace: Goes to the next page in history
* Backspace: Goes to the previous page in history
* Alt + Left Arrow: Goes to the previous page in history
* Alt + Right Arrow: Goes to the next page in history
* Alt + D: Select the content in the address bar

Unfortunately it is impossible to implement switching to the next tab, without reimplementation tabs-model.cpp.
I think we could consider to use following private fields:
   QList<QObject*> m_tabs; //store all tabs data
   int current_tab_index; //store current tab index.

What do you think about such implementation?
It will simplify implementation and allow easily switching between tabs.

[Bartosz Kosiorek (gang65)]

The order of the tabs are changing during switching to next tab.
For example:

If you have tabs: "1 2 3 4"
and swittch to the next one ("2"), we will receive: "2 1 3 4"
and swittch to the next time , we will receive: "1 2 3 4"

I would like to ask Ubuntu UX, if it will be possible to not change order of tabs during switching?

In future we would like to support convergence, and it will be good to not rewrite webbrowser-app application.
Please let me know what do you think about that.

[Giorgio Venturi (giorgio-venturi-deactivatedaccount)]

On desktop & tablet, the order of tabs will not change

https://docs.google.com/a/canonical.com/presentation/d/1ggKmkxUFR5xCBcvkjJ4On9b4iKzEqcycz4hjc16tBGo/edit#slide=id.g2bb58620d_040

[Olivier Tilloy (osomon)]

Giorgio, what’s the rationale for the [OSK] marker in the title? This is about adding physical keyboard shortcuts (e.g. Ctrl+T, Alt+Backspace, …), not sure how this relates to the on-screen keyboard on touch devices.

[Giorgio Venturi (giorgio-venturi-deactivatedaccount)]

Sorry I got confused... I must have done something like 30 bugs today

> On 16 Mar 2015, at 19:21, Olivier Tilloy <email address hidden> wrote:
>
> Giorgio, what’s the rationale for the [OSK] marker in the title? This is
> about adding physical keyboard shortcuts (e.g. Ctrl+T, Alt+Backspace,
> …), not sure how this relates to the on-screen keyboard on touch
> devices.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1287361
>
> Title:
> [OSK] add support for keyboard shortcuts
>
> Status in Ubuntu UX bugs:
> In Progress
> Status in Web Browser App:
> In Progress
> Status in webbrowser-app package in Ubuntu:
> In Progress
>
> Bug description:
> need to add commands similar to the other apps so it works well on the
> desktop:
>
> - fullscreen mode and toggle (via function key)
> - esc key to toggle out of fullscreen
> - ctrl-l to display the url bar and select all text in it
> - keyboard shortcuts for navigation (back, forward) - check what chrome/chromium/firefox does here
> - keyboard shortcut for reload a page
> - keyboard shortcut to display history
> - others???
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-ux/+bug/1287361/+subscriptions

[Launchpad Janitor (janitor)]

This bug was fixed in the package webbrowser-app - 0.23+15.10.20150618-0ubuntu1

---------------
webbrowser-app (0.23+15.10.20150618-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Michael Terry ]
  * Fix spelling of OK in private browsing dialog.

  [ Olivier Tilloy ]
  * Actually push URLs to the clipboard. For some reason setting the
    "text/url-list" mime type doesn’t seem to work (or other
    applications do not implement pasting this kind of data), but
    "text/plain" works well enough for this purpose. (LP: #1463435)
  * Do not honour fullscreen requests silently at the Ubuntu WebView
    level. Instead delegate that behaviour to the webview implementation
    used by the browser and the webapp container. (LP: #1464249)
  * Toggle application-level fullscreen when pressing F11. (LP:
    #1464333)

  [ Ugo Riboni ]
  * Make the browser chrome usable on desktop by implementing common
    keyboard shortcuts and behaviors that users normally expect in such
    an app (LP: #1287361)

 -- CI Train Bot <email address hidden> Thu, 18 Jun 2015 08:12:37 +0000