Reset an alarm doesn't return the properties to their default values

[Leo Arias]

When I reset a repeating alarm with multiple daysOfWeek set, daysOfWeek is not reset to Alarm.AutoDetect.

To reproduce:
Apply the patch in http://paste.ubuntu.com/8366602/ and run the tests.

FAIL! : qmltestrunner::AlarmAPI::test_resetAlarmMustSetDefaultPropertiesValues() property daysOfWeek
   Actual (): 4
   Expected (): 128
   Loc: [/home/elopio/workspace/canonical/ubuntu-ui-toolkit/trunk/tests/unit_x11/tst_components/tst_alarms.qml(266)]

[Zsombor Egri (zsombi)]

Indeed the default value should be AutoDetect, but actually that one we cannot really keep. As the AutoDetect should update daysOfWeek immediately when set. Meaning that when someone sets that as value for daysOfWeek, and immediately checks the value of the property, it should never return AutoDetect alone, but a masked dsysOfWeek depending on the alarm date and type.

So in that sense the paste bin test is wrong.

[Zsombor Egri (zsombi)]

Thinking a bit on the topic, I think you are right, if the alarm default dow is auto detect, then we should return to that, and not keep on a specific date as AutoDetect dow depends on the date set. Raising importance to high.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1347+15.04.20141126-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1347+15.04.20141126-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Expose refresh() function in revision 1 (Ubuntu.Components 1.1).
    Fixes LP: #1380559
  * Alarm adaptation refactored to support change granular model
    updates. Fixes LP: #1322558, LP: #1360359, LP: #1370649,
    LP: #1380553
  * Fix Header thin divider margins, restored to original no-margins.
    Fixes LP: #1380766.

  [ Tim Peeters ]
  * Add ensure_visible() function to header AP helper.
    Fixes LP: #1363591

  [ Albert Astals Cid ]
  * Add context support for i18n.tr calls. This allows to have strings
    like "All" translated to two different strings in the translated
    language if different contexts are given. Fixes LP: #1394904
 -- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 08:33:25 +0000