It's not safe to override the show header autopilot helper
Bug #1363591 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Tim Peeters | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
New
|
Undecided
|
Unassigned | ||
Bug Description
We need a method called ensure_visible on the header autopilot helper.
This method will be public, so it will be safe for apps to override it if they change the header behaviour. For example, on the gallery, clicking on the center of the app will show the header. Swiping won't.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/ensureVisible
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
- Leo Arias (community): Approve (code review)
-
Diff: 154 lines (+79/-7)3 files modifiedtests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_header.py (+7/-7)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.HideShowTestCase.qml (+44/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py (+28/-0)
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Tim Peeters (tpeeters) |
| status: | Confirmed → In Progress |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Tim Peeters (tpeeters) |
| status: | New → In Progress |
| no longer affects: | ubuntu-ui-toolkit |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1347+
---------------
ubuntu-ui-toolkit (1.1.1347+
[ Zsombor Egri ]
* Expose refresh() function in revision 1 (Ubuntu.Components 1.1).
Fixes LP: #1380559
* Alarm adaptation refactored to support change granular model
updates. Fixes LP: #1322558, LP: #1360359, LP: #1370649,
LP: #1380553
* Fix Header thin divider margins, restored to original no-margins.
Fixes LP: #1380766.
[ Tim Peeters ]
* Add ensure_visible() function to header AP helper.
Fixes LP: #1363591
[ Albert Astals Cid ]
* Add context support for i18n.tr calls. This allows to have strings
like "All" translated to two different strings in the translated
language if different contexts are given. Fixes LP: #1394904
-- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 08:33:25 +0000