SSOCredentials signals must always pass the app_name

Bug #621377 reported by Natalia Bidart on 2010-08-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Single Sign On Client
High
Alejandro J. Cura
ubuntu-sso-client (Ubuntu)
High
Ubuntu One Client Engineering team
Nominated for Maverick by Rodrigo Moya

Bug Description

Signals

AuthorizationDenied(self):
CredentialsFound(self, app_name):
CredentialsError(self, error):

must pass the app_name to the caller, so it can check if the signal corresponds to its dbus call.
The app_name must be provided in the GTK signals as well, and so the error if any.

Related branches

Changed in ubuntu-sso-client:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Naty Bidart (nataliabidart)
Changed in ubuntu-sso-client (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
importance: Medium → High
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
milestone: none → ubuntu-10.10-beta
tags: added: desktop+ u1-maverick
Changed in ubuntu-sso-client:
assignee: Naty Bidart (nataliabidart) → Alejandro J. Cura (alecu)
status: Confirmed → Fix Committed
Alejandro J. Cura (alecu) wrote :

This problem means that two programs that use this service at the same time won't be able to tell who the signal was sent for.

In order to avoid this we need to add the app_name as an argument to all these signals so the users of this service can tell the signals apart.

Right now this service is used by Ubuntu One and the Software Center, so it may make sense to do this change before more programs start using it.

Changed in ubuntu-sso-client:
status: Fix Committed → In Progress
dobey (dobey) on 2010-08-23
Changed in ubuntu-sso-client:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-sso-client - 0.99.2-0ubuntu1

---------------
ubuntu-sso-client (0.99.2-0ubuntu1) maverick; urgency=low

  * New upstream release:

  [ Natalia Bidart ]
  * Ping an URL when the login was successful (LP: #621226).
  * Signals propagates the app_name to be later check by the GUI so only those
    belonging to it will be processed (LP: #621377).

  [ Natalia Bidart ]
  * Added modifications to setup.py and a new po/ directory with the file that has
    strings that need translation (LP: #616515).

  [ Rodrigo Moya ]
  * Add clear_token DBus API (LP: #622833).

  [ Alejandro J. Cura ]
  * Make all the signals return the errors as dictionaries (LP: #616105).
  * Credential* signals should return the app_name as well (LP: #621377).

  [ Alejandro J. Cura ]
  * Use Ubuntu One OAuth credentials if they are already stored in the keyring
    (LP: #617355).

  [ Natalia Bidart ]
  * Final outcome (as signal) is emitted after user closes the main window (LP:
    #620008).
 -- Natalia Bidart (nessita) <email address hidden> Tue, 24 Aug 2010 12:50:57 -0300

Changed in ubuntu-sso-client (Ubuntu):
status: Triaged → Fix Released
Changed in ubuntu-sso-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers