Ubuntu RTM
unity-scopes-shell package

Track app sales per partner

Bug #1389273 reported by Martin Albisetti on 2014-11-04

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	Undecided	Unassigned	Canonical System Image ww51-2014
unity-scopes-api (Ubuntu)	Fix Released	Undecided	Unassigned
unity-scopes-api (Ubuntu RTM)	Fix Released	Undecided	Unassigned
unity-scopes-shell (Ubuntu)	Fix Released	Critical	Paweł Stołowski
unity-scopes-shell (Ubuntu RTM)	Fix Released	Critical	Paweł Stołowski

Bug Description

We need to track what app sales come from which partner, by sending the partner string when performing a purchase.

For documentation on what the server expects, see:
https://wiki.ubuntu.com/AppStore/Interfaces/Purchases#purchases

The code for each partner needs to be specified in the OEM image.

See original description

Tags:

Related branches

lp:~dobey/pay-ui/send-partner-id

Merged into lp:pay-ui at revision 83

Ted Gould (community): Approve on 2014-11-05

PS Jenkins bot (community): Approve (continuous-integration) on 2014-11-05

lp:~stolowski/unity-scopes-shell/partner-id-vivid

Merged into lp:unity-scopes-shell at revision 170

dobey (community): Approve on 2014-11-11

PS Jenkins bot (community): Approve (continuous-integration) on 2014-11-05

lp:~stolowski/unity-scopes-shell/partner-id-rtm

Merged into lp:unity-scopes-shell/rtm-14.09 at revision 133

Pete Woods (community): Approve on 2014-11-21

lp:ubuntu/vivid/unity-scopes-shell

lp:~stolowski/unity-scopes-api/remote-scopes-partner-id

Merged into lp:unity-scopes-api/devel at revision 557

Marcus Tomlinson (community): Approve on 2014-12-09

Michi Henning (community): Needs Fixing on 2014-12-08

Superseded for merging into lp:unity-scopes-api

Unity Team: Pending requested 2014-12-08

Diff: 8219 lines (+2811/-992)

151 files modified

CMakeLists.txt (+9/-2)
CONFIGFILES (+11/-7)
RELEASE_NOTES.md (+5/-0)
STRUCTS (+2/-1)
debian/changelog (+7/-0)
debian/control (+1/-0)
debian/libunity-scopes3.symbols (+22/-8)
doc/tutorial.dox (+33/-5)
include/unity/scopes/Annotation.h (+43/-29)
include/unity/scopes/CMakeLists.txt (+1/-0)
include/unity/scopes/Runtime.h (+14/-4)
include/unity/scopes/ScopeBase.h (+2/-2)
include/unity/scopes/ScopeMetadata.h (+12/-6)
include/unity/scopes/internal/ActivationQueryObject.h (+5/-2)
include/unity/scopes/internal/Logger.h (+75/-0)
include/unity/scopes/internal/MWRegistry.h (+1/-0)
include/unity/scopes/internal/MiddlewareBase.h (+1/-0)
include/unity/scopes/internal/ObjectImpl.h (+4/-1)
include/unity/scopes/internal/PreviewQueryObject.h (+4/-1)
include/unity/scopes/internal/PreviewReplyImpl.h (+3/-1)
include/unity/scopes/internal/QueryCtrlImpl.h (+4/-1)
include/unity/scopes/internal/QueryObject.h (+9/-3)
include/unity/scopes/internal/RegistryObject.h (+11/-4)
include/unity/scopes/internal/ReplyImpl.h (+3/-1)
include/unity/scopes/internal/ReplyObject.h (+1/-0)
include/unity/scopes/internal/RuntimeImpl.h (+9/-9)
include/unity/scopes/internal/ScopeConfig.h (+4/-2)
include/unity/scopes/internal/ScopeMetadataImpl.h (+6/-3)
include/unity/scopes/internal/ScopeObjectBase.h (+0/-3)
include/unity/scopes/internal/SearchReplyImpl.h (+5/-2)
include/unity/scopes/internal/SettingsDB.h (+14/-4)
include/unity/scopes/internal/TaskWrapper.h (+2/-2)
include/unity/scopes/internal/smartscopes/SSQueryObject.h (+4/-2)
include/unity/scopes/internal/smartscopes/SSScopeObject.h (+2/-1)
include/unity/scopes/internal/smartscopes/SmartScope.h (+1/-0)
include/unity/scopes/internal/smartscopes/SmartScopesClient.h (+10/-4)
include/unity/scopes/internal/zmq_middleware/ObjectAdapter.h (+4/-1)
include/unity/scopes/internal/zmq_middleware/ZmqMiddleware.h (+4/-1)
include/unity/scopes/testing/ScopeMetadataBuilder.h (+2/-1)
include/unity/scopes/utility/BufferedResultForwarder.h (+114/-0)
include/unity/scopes/utility/CMakeLists.txt (+7/-0)
include/unity/scopes/utility/internal/BufferedResultForwarderImpl.h (+68/-0)
include/unity/scopes/utility/internal/BufferedSearchReplyImpl.h (+92/-0)
include/unity/scopes/utility/internal/CMakeLists.txt (+3/-0)
scoperegistry/DirWatcher.cpp (+27/-14)
scoperegistry/DirWatcher.h (+5/-2)
scoperegistry/FindFiles.cpp (+10/-5)
scoperegistry/ScopesWatcher.cpp (+110/-99)
scoperegistry/ScopesWatcher.h (+5/-3)
scoperegistry/scoperegistry.cpp (+7/-6)
scoperunner/scoperunner.cpp (+3/-4)
src/scopes/CMakeLists.txt (+1/-0)
src/scopes/Runtime.cpp (+2/-2)
src/scopes/ScopeMetadata.cpp (+8/-3)
src/scopes/internal/ActivationQueryObject.cpp (+9/-8)
src/scopes/internal/AnnotationImpl.cpp (+4/-5)
src/scopes/internal/CMakeLists.txt (+1/-0)
src/scopes/internal/CannedQueryImpl.cpp (+1/-1)
src/scopes/internal/DepartmentImpl.cpp (+1/-1)
src/scopes/internal/Logger.cpp (+165/-0)
src/scopes/internal/MWRegistry.cpp (+4/-0)
src/scopes/internal/MiddlewareBase.cpp (+0/-6)
src/scopes/internal/ObjectImpl.cpp (+3/-2)
src/scopes/internal/OnlineAccountClientImpl.cpp (+16/-2)
src/scopes/internal/PreviewQueryObject.cpp (+9/-9)
src/scopes/internal/PreviewReplyImpl.cpp (+6/-4)
src/scopes/internal/PreviewReplyObject.cpp (+0/-1)
src/scopes/internal/PreviewWidgetImpl.cpp (+2/-2)
src/scopes/internal/QueryCtrlImpl.cpp (+6/-6)
src/scopes/internal/QueryObject.cpp (+14/-14)
src/scopes/internal/RegistryImpl.cpp (+3/-4)
src/scopes/internal/RegistryObject.cpp (+120/-78)
src/scopes/internal/ReplyImpl.cpp (+10/-14)
src/scopes/internal/ReplyObject.cpp (+5/-9)
src/scopes/internal/RuntimeImpl.cpp (+36/-27)
src/scopes/internal/ScopeConfig.cpp (+26/-10)
src/scopes/internal/ScopeImpl.cpp (+5/-5)
src/scopes/internal/ScopeLoader.cpp (+0/-1)
src/scopes/internal/ScopeMetadataImpl.cpp (+43/-14)
src/scopes/internal/ScopeObject.cpp (+14/-15)
src/scopes/internal/SearchReplyImpl.cpp (+8/-7)
src/scopes/internal/SettingsDB.cpp (+32/-10)
src/scopes/internal/smartscopes/HttpClientQt.cpp (+5/-1)
src/scopes/internal/smartscopes/HttpClientQtThread.cpp (+7/-1)
src/scopes/internal/smartscopes/SSQueryObject.cpp (+10/-9)
src/scopes/internal/smartscopes/SSRegistryObject.cpp (+22/-14)
src/scopes/internal/smartscopes/SSScopeObject.cpp (+8/-8)
src/scopes/internal/smartscopes/SmartScope.cpp (+55/-32)
src/scopes/internal/smartscopes/SmartScopesClient.cpp (+103/-51)
src/scopes/internal/zmq_middleware/ObjectAdapter.cpp (+17/-18)
src/scopes/internal/zmq_middleware/QueryCtrlI.cpp (+4/-3)
src/scopes/internal/zmq_middleware/QueryI.cpp (+3/-2)
src/scopes/internal/zmq_middleware/RegistryI.cpp (+6/-5)
src/scopes/internal/zmq_middleware/ReplyI.cpp (+5/-4)
src/scopes/internal/zmq_middleware/ScopeI.cpp (+7/-7)
src/scopes/internal/zmq_middleware/ServantBase.cpp (+1/-1)
src/scopes/internal/zmq_middleware/StateReceiverI.cpp (+3/-2)
src/scopes/internal/zmq_middleware/StopPublisher.cpp (+0/-1)
src/scopes/internal/zmq_middleware/ZmqMiddleware.cpp (+37/-40)
src/scopes/internal/zmq_middleware/ZmqScope.cpp (+6/-4)
src/scopes/internal/zmq_middleware/ZmqSender.cpp (+0/-6)
src/scopes/testing/ScopeMetadataBuilder.cpp (+15/-6)
src/scopes/utility/BufferedResultForwarder.cpp (+161/-0)
src/scopes/utility/CMakeLists.txt (+7/-0)
src/scopes/utility/internal/BufferedResultForwarderImpl.cpp (+121/-0)
src/scopes/utility/internal/BufferedSearchReplyImpl.cpp (+158/-0)
src/scopes/utility/internal/CMakeLists.txt (+6/-0)
test/gtest/CMakeLists.txt (+3/-3)
test/gtest/scopes/Activation/Activation_test.cpp (+4/-4)
test/gtest/scopes/Annotation/Annotation_test.cpp (+4/-8)
test/gtest/scopes/CMakeLists.txt (+1/-0)
test/gtest/scopes/CannedQuery/CannedQuery_test.cpp (+3/-3)
test/gtest/scopes/Filters/Filters_test.cpp (+3/-3)
test/gtest/scopes/IdleShutdown/IdleShutdown_test.cpp (+4/-4)
test/gtest/scopes/Invocation/Invocation_test.cpp (+9/-9)
test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp (+0/-43)
test/gtest/scopes/Registry/Registry_test.cpp (+92/-60)
test/gtest/scopes/Registry/scopes/testscopeA/testscopeA.ini.in (+2/-1)
test/gtest/scopes/Registry/scopes/testscopeB/testscopeB.cpp (+1/-1)
test/gtest/scopes/ReplyReaper/ReplyReaper_test.cpp (+6/-6)
test/gtest/scopes/Runtime/Runtime_test.cpp (+9/-9)
test/gtest/scopes/internal/MiddlewareFactory/MiddlewareFactory_test.cpp (+2/-2)
test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp (+2/-2)
test/gtest/scopes/internal/ResultReplyObject/ResultReplyObject_test.cpp (+1/-1)
test/gtest/scopes/internal/RuntimeImpl/RuntimeImpl_test.cpp (+5/-5)
test/gtest/scopes/internal/ScopeConfig/CMakeLists.txt (+6/-6)
test/gtest/scopes/internal/ScopeConfig/ScopeConfig_test.cpp (+16/-13)
test/gtest/scopes/internal/ScopeConfig/bad_keywords.ini.in (+1/-1)
test/gtest/scopes/internal/ScopeConfig/complete_config.ini.in (+2/-1)
test/gtest/scopes/internal/ScopeConfig/empty_keywords.ini.in (+1/-1)
test/gtest/scopes/internal/ScopeConfig/single_keyword.ini.in (+1/-1)
test/gtest/scopes/internal/ScopeMetadataImpl/ScopeMetadataImpl_test.cpp (+34/-13)
test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp (+16/-14)
test/gtest/scopes/internal/smartscopes/RaiiServer.h (+2/-2)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/CMakeLists.txt (+4/-0)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/FakeSss.py (+10/-2)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+34/-11)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/partnerid (+1/-0)
test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp (+5/-5)
test/gtest/scopes/internal/zmq_middleware/ObjectAdapter/ObjectAdapter_test.cpp (+18/-6)
test/gtest/scopes/internal/zmq_middleware/PubSub/PubSub_test.cpp (+5/-5)
test/gtest/scopes/internal/zmq_middleware/ServantBase/ServantBase_test.cpp (+2/-2)
test/gtest/scopes/testing/CMakeLists.txt (+4/-4)
test/gtest/scopes/testing/IsolatedScope/IsolatedScope_test.cpp (+6/-1)
test/gtest/scopes/utility/BufferedResultForwarder/BufferedResultForwarder_test.cpp (+329/-0)
test/gtest/scopes/utility/BufferedResultForwarder/CMakeLists.txt (+4/-0)
test/gtest/scopes/utility/CMakeLists.txt (+1/-0)
tools/create_globalheader.py (+10/-11)
tools/formatcode.in (+6/-2)
unity-scopes.map (+12/-6)
valgrind-suppress (+8/-0)

lp:ubuntu/vivid-proposed/unity-scopes-api

lp:~stolowski/unity-scopes-api/remote-scopes-partner-id-rtm

Merged into lp:unity-scopes-api/rtm-14.09 at revision 255

Michi Henning (community): Approve on 2014-12-16

Pete Woods: Pending requested 2014-12-16

dobey (dobey) on 2014-11-04

Changed in pay-ui:
status:	New → Triaged
importance:	Undecided → Critical
tags:	added: rtm14
information type:	Public → Private

dobey (dobey) on 2014-11-04

information type:

Private → Public

Matias Bordese (matiasb) on 2014-11-04

description:

updated

Olli Ries (ories) on 2014-11-04

tags:

added: ota-1

dobey (dobey) on 2014-11-04

Changed in pay-ui:
status:	Triaged → In Progress
assignee:	nobody → Rodney Dawes (dobey)

dobey (dobey) on 2014-11-05

Changed in unity-scopes-shell (Ubuntu):
importance:	Undecided → Critical
Changed in unity-scopes-shell (Ubuntu RTM):
importance:	Undecided → Critical

Paweł Stołowski (stolowski) on 2014-11-05

no longer affects:	ubuntu-rest-scopes
no longer affects:	savilerow

dobey (dobey) on 2014-11-05

Changed in unity-scopes-shell (Ubuntu):
status:	New → In Progress
assignee:	nobody → Pawel Stolowski (stolowski)
Changed in unity-scopes-shell (Ubuntu RTM):
status:	New → Triaged
assignee:	nobody → Pawel Stolowski (stolowski)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-05:

Fix committed into lp:pay-ui at revision 83, scheduled for release in pay-ui, milestone Unknown

Changed in pay-ui:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-12-01:

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20141128-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20141128-0ubuntu1) vivid; urgency=low

  [ Pete Woods ]
  * Write the scope settings using UTF-8 to match up with the scope
    regsitry (LP: #1381010)
  * Move QNetworkAccessManager onto correct thread
  * Fix crash exposed by today scope (LP: #1396526)

  [ Pawel Stolowski ]
  * Fix version check for unity api to match version required by
    src/Unity/CMakeLists.txt.
  * Read /custom/partner-id value (if present) and pass it with user-
    agent hint. (LP: #1389273)

[ Albert Astals ]
* Don't call Result::contains and then Result::value
-- Ubuntu daily release <email address hidden> Fri, 28 Nov 2014 08:52:43 +0000

Changed in unity-scopes-shell (Ubuntu):
status:	In Progress → Fix Released

Pat McGowan (pat-mcgowan) on 2014-12-04

Changed in canonical-devices-system-image:
status:	New → In Progress

Revision history for this message

Paweł Stołowski (stolowski) wrote on 2014-12-08:

As explained in #1399401, partner-id needs to be honoured also by scope registry when obtaining list of remote scopes; linking unity-scopes-api with this bug.

Pat McGowan (pat-mcgowan) on 2014-12-10

Changed in canonical-devices-system-image:
status:	In Progress → Confirmed
milestone:	none → ww51-2014

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-12-11:

This bug was fixed in the package unity-scopes-api - 0.6.10+15.04.20141210.2-0ubuntu1

---------------
unity-scopes-api (0.6.10+15.04.20141210.2-0ubuntu1) vivid; urgency=medium

  [ Marcus Tomlinson ]
  * Renamed "Tags" scope .ini option to "Keywords".
  * Added support for IsAggregator scope .ini option.

  [ Pawel Stolowski ]
  * Pass partner-id via UserAgent with remote-scopes call (LP: #1389273).
  * Implemented BufferedResultForwarder API.
  * Allow multi-arch click packages for scopes (LP: #1398998).
  * Use SIGNON_POLICY_NO_USER_INTERACTION by default unless UNITY_SCOPES_OA_UI_POLICY
    is set (LP: #1380914).

[ Ubuntu daily release ]
* debian/libunity-scopes3.symbols: auto-update to released version
-- Ubuntu daily release <email address hidden> Wed, 10 Dec 2014 12:59:48 +0000

Changed in unity-scopes-api (Ubuntu):
status:	New → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-12-16:

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20141210~rtm-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20141210~rtm-0ubuntu1) 14.09; urgency=low

[ Pete Woods ]
* Fix today scope crash (LP: #1394155)

  [ Pawel Stolowski ]
  * Read /custom/partner-id value (if present) and pass it with user-
    agent hint. (LP: #1389273)
-- Ubuntu daily release <email address hidden> Wed, 10 Dec 2014 16:46:01 +0000

Changed in unity-scopes-shell (Ubuntu RTM):
status:	Triaged → Fix Released

dobey (dobey) on 2014-12-16

Changed in pay-ui:
status:	Fix Committed → Fix Released

Pat McGowan (pat-mcgowan) on 2015-01-05

Changed in canonical-devices-system-image:
status:	Confirmed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-01-07:

This bug was fixed in the package unity-scopes-api - 0.6.9+15.04.20141216.2~rtm-0ubuntu1

---------------
unity-scopes-api (0.6.9+15.04.20141216.2~rtm-0ubuntu1) 14.09; urgency=low

  [ Pawel Stolowski ]
  * Use get() on future of the http request to get exceptions reported
    when error occur (std::future::wait() doesn't throw). Cherry-picked
    trunk rev. 274. (LP: #1401560)
  * Cherry-picked support for passing partner id from /custom/partner-id
    with remote-scopes requests maded by Smart Scopes Proxy. (LP:
    #1389273)

[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Tue, 16 Dec 2014 22:07:29 +0000

Changed in unity-scopes-api (Ubuntu RTM):
status:	New → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1399401

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntu RTMunity-scopes-shell package

Track app sales per partner

Bug Description

Related branches

Duplicates of this bug

Other bug subscribers

Remote bug watches

Ubuntu RTM
unity-scopes-shell package