OnlineAccountsClient::Setup::exec() should execute a signon auth session

[Marcus Tomlinson]

There is a fix to unity8 coming up that will soon be hiding the OA splash screen. Hiding the splash screen is great for 50% of the situations that it pops up, but there is a point where its actually nice to see that something is happening.

With scopes, after the OnlineAccountsClient::Setup class returns from exec(), the shell then calls signon_auth_session_process_async() to request an access token. Thats when seeing the splash screen is useful as the user can see that something is still happening. With that slash screen hidden, the focus will be returned to the scope without any indication that the sign on process is still busy.

Could we have the OnlineAccountsClient::Setup::exec() method execute the auth session itself before returning / sending the “finished” signal? That way you'll stay on the setup screen until the oauth token has been granted, hence returning to the scope when all is ready to go.

[Marcus Tomlinson (marcustomlinson)]

Btw, this is the bug that, when fixed, will cause the OA splash screen to be hidden: https://bugs.launchpad.net/qtmir/+bug/1352251

[Victor Tuson Palau (vtuson)]

tagging this as ota-1

[Alberto Mardegan (mardy)]

I've attached a branch which attempts to fix this issue. Testing is welcome.

On the other hand, bug 1352251 is probably not going to be fixed (as I understood after discussing with Saviq on IRC), and at least it's not marked as an ota-1 bug.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20141210-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20141210-0ubuntu1) vivid; urgency=low

  [ Marcus Tomlinson ]
  * Set UNITY_SCOPES_OA_UI_POLICY on entry to Scope::loginToAccount()
    (LP: #1380914)

  [ Xavi Garcia ]
  * Added a signal in the SettingsModel and connect it to the
    invalidateResults slot in Scope.
 -- Ubuntu daily release <email address hidden> Wed, 10 Dec 2014 11:19:38 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings-online-accounts - 0.5+15.04.20150115~rtm-0ubuntu1

---------------
ubuntu-system-settings-online-accounts (0.5+15.04.20150115~rtm-0ubuntu1) 14.09; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Alberto Mardegan ]
  * Use trusted prompts for SignOnUi (LP: #1380914)
 -- Ubuntu daily release <email address hidden> Thu, 15 Jan 2015 15:34:46 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-scopes-api - 0.6.9+15.04.20150115~rtm-0ubuntu1

---------------
unity-scopes-api (0.6.9+15.04.20150115~rtm-0ubuntu1) 14.09; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Marcus Tomlinson ]
  * Use SIGNON_POLICY_NO_USER_INTERACTION by default unless
    UNITY_SCOPES_OA_UI_POLICY env var is set. Update the accounts we
    already know about when refresh_service_statuses() is called. (LP:
    #1380914, #1398813)
 -- Ubuntu daily release <email address hidden> Thu, 15 Jan 2015 15:25:50 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20150115~rtm-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20150115~rtm-0ubuntu1) 14.09; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Marcus Tomlinson ]
  * Set UNITY_SCOPES_OA_UI_POLICY on entry to Scope::loginToAccount().
    Animate the loading bar on the scope while OA retrieves a token.
    (LP: #1380914, #1401860)
 -- Ubuntu daily release <email address hidden> Thu, 15 Jan 2015 15:32:13 +0000