new ListItem click does not work without leading/trailing actions
Bug #1399025 reported by
Tim Peeters
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri | ||
Vivid |
New
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
New
|
Undecided
|
Unassigned |
Bug Description
When a ListItem is defined without leading/trailing actions, there is no onClicked signal, and there is no highlight when the list item is being pressed. See http://
Uncommenting line 93 which enables trailing actions makes onClicked and pressed work again.
Related branches
lp:~zsombi/ubuntu-ui-toolkit/75-listitem-highlight
- Tim Peeters: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 550 lines (+162/-55)8 files modifiedcomponents.api (+1/-1)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+88/-24)
modules/Ubuntu/Components/plugin/uclistitem.h (+3/-3)
modules/Ubuntu/Components/plugin/uclistitem_p.h (+3/-2)
modules/Ubuntu/Components/plugin/uclistitemactionsattached.cpp (+3/-3)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_uclistitem.py (+4/-8)
tests/resources/listitems/ListItemTest.qml (+9/-0)
tests/unit_x11/tst_components/tst_listitem.qml (+51/-14)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Triaged → In Progress |
To post a comment you must log in.
Because it has been requested like that to be. The docs say (somewhere in #95 at highlightPolicy) that no highlight in case there's no leading/trailing actions list, or action attached, or there's no active component in the list item. No highlight also means no click/pressAndHold.
Bug #1362305 also states that no animation (highlight) should happen if no action is attached to a list item. That means at least one of the above should match in order to have highlight, thus click happening.