new ListItem click does not work without leading/trailing actions

Bug #1399025 reported by Tim Peeters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Zsombor Egri
Vivid
New
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
New
Undecided
Unassigned

Bug Description

When a ListItem is defined without leading/trailing actions, there is no onClicked signal, and there is no highlight when the list item is being pressed. See http://pastebin.ubuntu.com/9359166/

Uncommenting line 93 which enables trailing actions makes onClicked and pressed work again.

Related branches

Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Because it has been requested like that to be. The docs say (somewhere in #95 at highlightPolicy) that no highlight in case there's no leading/trailing actions list, or action attached, or there's no active component in the list item. No highlight also means no click/pressAndHold.

Bug #1362305 also states that no animation (highlight) should happen if no action is attached to a list item. That means at least one of the above should match in order to have highlight, thus click happening.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Invalid
Revision history for this message
Zsombor Egri (zsombi) wrote :

Actually you are right, and there's hop need for any kind of highlightPolicy to be present, as we can detect whether an action is attached to a ListItem, i.e has clicked or pressAndHold connected to a slot. So in that sense the bug is valid.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Invalid → Triaged
importance: Undecided → High
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Tim Peeters (tpeeters) wrote :

thanks :)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1376+15.04.20150111-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1376+15.04.20150111-0ubuntu1) vivid; urgency=medium

  [ Tim Peeters ]
  * Add a preview of the new list items to the UITK component gallery.

  [ Zoltan Balogh ]
  * Update the test plan and fix the PPA string in case it contains backslash.
  * Added Dialog CPO to test if OSK pushes up the the dialog.

  [ Zsombor Egri ]
  * ListItem highlight is driven also by the connection of a slot to
    the clicked() signal. This will also be applied when pressAndHold
    signal will be introduced. Fixes LP: #1399025

  [ Giulio Collura ]
  * Force the removal of the previous 'contents' item by removing its parent.
    This way we ensure that the contents are correctly hidden, focused and
    removed, without destroying them. Fixes LP: #1341814 LP: #1400297
 -- Ubuntu daily release <email address hidden> Sun, 11 Jan 2015 18:57:02 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.