Why, when this is an upstream release for which Canonical is the upstream, are there local Debian patches included here?
+ * d/control:
+ - Add 'python3-packaging' as part of the runtime depends.
+ - Add 'python3-packaging' as part of the build depends.
+ - Add 'python3-yaml' as part of the build depends.
When making such packaging changes in an SRU, it should be documented in the changelog why they are necessary and justified. I can infer a reason for the python3-packaging addition from the debdiff, but shouldn't have to: the rationale should be documented so that there is no misunderstanding.
And it is not at all obvious from the debdiff why python3-yaml is added to the build-dependencies: it was already listed in setup.py before as a requirement but apparently didn't cause a build failure. So explanation is needed here.
+ - Add 'X-Python3-Version: >= 3.6' to ensure we use the python
+ revision that is supported. (LP #2038648)
Well this is pointless, since python3 is >= 3.6 in all releases after bionic and we don't do SRUs for bionic anymore.
+ - Add 'python3-boto3' to Suggests
This is also pretty pointless as nothing installs package Suggests: by default and users almost never look at this.
+ * New patches: collect- refactor- _format_ version. patch pacemaker- Use-pep440- formatted- version- on-comparison. patch cirrus- Run-tests- on-latest- daily-builds- for-ubuntu. patch processor- handle- msr-module- loading- via-predicate. patch
+ - d/p/0002-
+ - d/p/0003-
+ - d/p/0004-
+ - d/p/0005-
Why, when this is an upstream release for which Canonical is the upstream, are there local Debian patches included here?
+ * d/control:
+ - Add 'python3-packaging' as part of the runtime depends.
+ - Add 'python3-packaging' as part of the build depends.
+ - Add 'python3-yaml' as part of the build depends.
When making such packaging changes in an SRU, it should be documented in the changelog why they are necessary and justified. I can infer a reason for the python3-packaging addition from the debdiff, but shouldn't have to: the rationale should be documented so that there is no misunderstanding.
And it is not at all obvious from the debdiff why python3-yaml is added to the build-dependencies: it was already listed in setup.py before as a requirement but apparently didn't cause a build failure. So explanation is needed here.
+ - Add 'X-Python3-Version: >= 3.6' to ensure we use the python
+ revision that is supported. (LP #2038648)
Well this is pointless, since python3 is >= 3.6 in all releases after bionic and we don't do SRUs for bionic anymore.
+ - Add 'python3-boto3' to Suggests
This is also pretty pointless as nothing installs package Suggests: by default and users almost never look at this.