The Ubuntu-power-systems project

  1. Bug #1828596
  2. Comment #45

Comment 45 for bug 1828596

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2019-09-25 02:41 EDT-------
(In reply to comment #47)
> Hi, Hari.
>
> makedumpfile 1:1.6.5-1ubuntu1~18.04.2+cascardo2 on ppa:cascardo/ppa uses a
> try-reload instead. Can you test it, please?

Cascardo, try-reload is not considering fadump case (supported on powerpc).
For fadump case, need to check whether "/sys/kernel/fadump_registered" is `1`
before proceeding with unload/load..

A suggestion I have is to check for "systemctl is-active kdump-tools" and run
"kdump-config reload" if it returns true, instead of "kdump-config try-reload"
as that should cover for both kdump and fadump cases.

Also, shouldn't we account for races when multiple udev events are triggered
simultaneously by using locks or such?