Bisecting kernel gave bad results, recording here so that I can get another pair of eyes on things. Started with reverse bisect between v3.5 and v3.8 mainline source limited to changes on the ixgbevf source. Bisection indicated that the "fix" was a cleanup patch. Given that this was not the issue, I used the last tested boundaries from that as the input to a full kernel tree bisection which lead me to another 'fix' which only changes the formatting of debug printk in the tun driver.
Notes from debug:
- using ubuntu/images-testing/hvm/ubuntu-precise-daily-amd64-server-20140210 because it boots without sriov 'simple' attribute
- performing kernel bisect on mainline from v3.5..v3.8 limited to driver source ('git bisect start v3.8 v3.5 -- drivers/net/ethernet/intel/ixgbevf/')
$ git bisect log
# bad: [19f949f52599ba7c3f67a5897ac6be14bfcb1200] Linux 3.8
# good: [28a33cbc24e4256c143dce96c7d93bf423229f92] Linux 3.5
git bisect start 'v3.8' 'v3.5' '--' 'drivers/net/ethernet/intel/ixgbevf/'
# good: [5c60f81a2553213856b3bb80f18003e56a6a110d] ixgbevf: Add fix to VF to handle multi-descriptor buffers
git bisect good 5c60f81a2553213856b3bb80f18003e56a6a110d
# good: [810b6d7638a288216f99bd190470d67061c8bd88] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next
git bisect good 810b6d7638a288216f99bd190470d67061c8bd88
# bad: [6259a01fb2d458b4157918b2da0d0f42242a9d72] ixgbevf: Fix unnecessary dereference where local var is available.
git bisect bad 6259a01fb2d458b4157918b2da0d0f42242a9d72
# bad: [a5f9337bdc45bb8c13037bdb70d16fd9017bb83a] ixgbevf: fix possible use of uninitialized variable
git bisect bad a5f9337bdc45bb8c13037bdb70d16fd9017bb83a
# bad: [46acc460c07b5c74287560a00b6cbc6111136ab6] eth: Make is_link_local() consistent with other address tests
git bisect bad 46acc460c07b5c74287560a00b6cbc6111136ab6
# first bad commit: [46acc460c07b5c74287560a00b6cbc6111136ab6] eth: Make is_link_local() consistent with other address tests
==============================================================================
46acc460c07b5c74287560a00b6cbc6111136ab6 is the first bad commit
commit 46acc460c07b5c74287560a00b6cbc6111136ab6
Author: Ben Hutchings <email address hidden>
Date: Thu Nov 1 09:11:11 2012 +0000
eth: Make is_link_local() consistent with other address tests
Function name should include '_ether_addr'.
Return type should be bool.
Parameter name should be 'addr' not 'dest' (also matching kernel-doc).
Signed-off-by: Ben Hutchings <email address hidden>
Acked-by: John Fastabend <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
- Used last good/bad from prior search as input to a bisect operation on the full tree source ('git bisect start 46acc46 810b6d7')
$ git bisect log
# bad: [46acc460c07b5c74287560a00b6cbc6111136ab6] eth: Make is_link_local() consistent with other address tests
# good: [810b6d7638a288216f99bd190470d67061c8bd88] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next
git bisect start '46acc46' '810b6d7'
# bad: [9750a3ade7b635a18f04371b4fddad0de0b4e6d8] cpsw: support both silicon versions
git bisect bad 9750a3ade7b635a18f04371b4fddad0de0b4e6d8
# bad: [dd87b22f9096863adfd5daf281beb0a83379bd8f] bfin_mac: offer a PTP Hardware Clock.
git bisect bad dd87b22f9096863adfd5daf281beb0a83379bd8f
# bad: [96442e42429e5f268ab97a3586c7694a3acc55a7] tuntap: choose the txq based on rxq
git bisect bad 96442e42429e5f268ab97a3586c7694a3acc55a7
# bad: [6e914fc70793f540015bd99744cd456b8d7fdfbd] tuntap: RCUify dereferencing between tun_struct and tun_file
git bisect bad 6e914fc70793f540015bd99744cd456b8d7fdfbd
# bad: [54f968d6efdbf7dec36faa44fc11f01b0e4d1990] tuntap: move socket to tun_file
git bisect bad 54f968d6efdbf7dec36faa44fc11f01b0e4d1990
# bad: [1e5883382c3287a61aeebc33a301fd50f3a1005b] tuntap: log the unsigned informaiton with %u
git bisect bad 1e5883382c3287a61aeebc33a301fd50f3a1005b
# first bad commit: [1e5883382c3287a61aeebc33a301fd50f3a1005b] tuntap: log the unsigned informaiton with %u
$ git bisect bad
\1e5883382c3287a61aeebc33a301fd50f3a1005b is the first bad commit
commit 1e5883382c3287a61aeebc33a301fd50f3a1005b
Author: Jason Wang <email address hidden>
Date: Wed Oct 31 19:45:56 2012 +0000
tuntap: log the unsigned informaiton with %u
Signed-off-by: Jason Wang <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Bisecting kernel gave bad results, recording here so that I can get another pair of eyes on things. Started with reverse bisect between v3.5 and v3.8 mainline source limited to changes on the ixgbevf source. Bisection indicated that the "fix" was a cleanup patch. Given that this was not the issue, I used the last tested boundaries from that as the input to a full kernel tree bisection which lead me to another 'fix' which only changes the formatting of debug printk in the tun driver.
Notes from debug: images- testing/ hvm/ubuntu- precise- daily-amd64- server- 20140210 because it boots without sriov 'simple' attribute net/ethernet/ intel/ixgbevf/ ')
- using ubuntu/
- performing kernel bisect on mainline from v3.5..v3.8 limited to driver source ('git bisect start v3.8 v3.5 -- drivers/
$ git bisect log 7c3f67a5897ac6b e14bfcb1200] Linux 3.8 6c143dce96c7d93 bf423229f92] Linux 3.5 net/ethernet/ intel/ixgbevf/ ' 3856b3bb80f1800 3e56a6a110d] ixgbevf: Add fix to VF to handle multi-descriptor buffers 856b3bb80f18003 e56a6a110d 216f99bd190470d 67061c8bd88] Merge branch 'master' of git://git. kernel. org/pub/ scm/linux/ kernel/ git/jkirsher/ net-next 16f99bd190470d6 7061c8bd88 b4157918b2da0d0 f42242a9d72] ixgbevf: Fix unnecessary dereference where local var is available. 4157918b2da0d0f 42242a9d72 8c13037bdb70d16 fd9017bb83a] ixgbevf: fix possible use of uninitialized variable c13037bdb70d16f d9017bb83a 74287560a00b6cb c6111136ab6] eth: Make is_link_local() consistent with other address tests 4287560a00b6cbc 6111136ab6 74287560a00b6cb c6111136ab6] eth: Make is_link_local() consistent with other address tests ======= ======= ======= ======= ======= ======= ======= ======= ======= ======= = 4287560a00b6cbc 6111136ab6 is the first bad commit 4287560a00b6cbc 6111136ab6
# bad: [19f949f52599ba
# good: [28a33cbc24e425
git bisect start 'v3.8' 'v3.5' '--' 'drivers/
# good: [5c60f81a255321
git bisect good 5c60f81a2553213
# good: [810b6d7638a288
git bisect good 810b6d7638a2882
# bad: [6259a01fb2d458
git bisect bad 6259a01fb2d458b
# bad: [a5f9337bdc45bb
git bisect bad a5f9337bdc45bb8
# bad: [46acc460c07b5c
git bisect bad 46acc460c07b5c7
# first bad commit: [46acc460c07b5c
=======
46acc460c07b5c7
commit 46acc460c07b5c7
Author: Ben Hutchings <email address hidden>
Date: Thu Nov 1 09:11:11 2012 +0000
eth: Make is_link_local() consistent with other address tests
Function name should include '_ether_addr'.
Return type should be bool.
Parameter name should be 'addr' not 'dest' (also matching kernel-doc).
Signed-off-by: Ben Hutchings <email address hidden>
Acked-by: John Fastabend <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
- Used last good/bad from prior search as input to a bisect operation on the full tree source ('git bisect start 46acc46 810b6d7') 74287560a00b6cb c6111136ab6] eth: Make is_link_local() consistent with other address tests 216f99bd190470d 67061c8bd88] Merge branch 'master' of git://git. kernel. org/pub/ scm/linux/ kernel/ git/jkirsher/ net-next a18f04371b4fdda d0de0b4e6d8] cpsw: support both silicon versions 18f04371b4fddad 0de0b4e6d8 3adfd5daf281beb 0a83379bd8f] bfin_mac: offer a PTP Hardware Clock. adfd5daf281beb0 a83379bd8f 268ab97a3586c76 94a3acc55a7] tuntap: choose the txq based on rxq 68ab97a3586c769 4a3acc55a7 40015bd99744cd4 56b8d7fdfbd] tuntap: RCUify dereferencing between tun_struct and tun_file 0015bd99744cd45 6b8d7fdfbd dec36faa44fc11f 01b0e4d1990] tuntap: move socket to tun_file ec36faa44fc11f0 1b0e4d1990 a61aeebc33a301f d50f3a1005b] tuntap: log the unsigned informaiton with %u 61aeebc33a301fd 50f3a1005b a61aeebc33a301f d50f3a1005b] tuntap: log the unsigned informaiton with %u
$ git bisect log
# bad: [46acc460c07b5c
# good: [810b6d7638a288
git bisect start '46acc46' '810b6d7'
# bad: [9750a3ade7b635
git bisect bad 9750a3ade7b635a
# bad: [dd87b22f909686
git bisect bad dd87b22f9096863
# bad: [96442e42429e5f
git bisect bad 96442e42429e5f2
# bad: [6e914fc70793f5
git bisect bad 6e914fc70793f54
# bad: [54f968d6efdbf7
git bisect bad 54f968d6efdbf7d
# bad: [1e5883382c3287
git bisect bad 1e5883382c3287a
# first bad commit: [1e5883382c3287
$ git bisect bad a61aeebc33a301f d50f3a1005b is the first bad commit 61aeebc33a301fd 50f3a1005b
\1e5883382c3287
commit 1e5883382c3287a
Author: Jason Wang <email address hidden>
Date: Wed Oct 31 19:45:56 2012 +0000
tuntap: log the unsigned informaiton with %u
Signed-off-by: Jason Wang <email address hidden>
Signed-off-by: David S. Miller <email address hidden>