Comment 127 for bug 1068994

Revision history for this message
In , Dsd-o (dsd-o) wrote :

(In reply to comment #47)
> I believe the touch-grab-race-condition-56578-v2 patch series so far creates
> a problem with mouse input. In Sugar's Paint application, I can't paint
> anything by moving the mouse around with the button held down.
>
> Running xev, I can see that clicking and holding the mouse button doesn't
> actually trigger any events. Only when I release, ButtonPress and
> ButtonRelease appear in quick succession.

I have reproduced this by checking out the git branch in question and building it directly, so it was not a side effect of my earlier attempt (above) where I had backported this to 1.13.3.

The problem can be reproduced very easily: xinit /usr/bin/xev (running over ssh from another machine, to be able to see stdout)

Move the mouse cursor to the top left (where the xev window is). Click and hold the mouse button, and keep holding. No output from xev. Now release the mouse button, ButtonPress and ButtonRelease arrive at the same time. No touch input is needed to see this problem.

A few churns of "git bisect" later I have tracked this down to:

3e1515898545b0ed9e1f0794800c07061c8c8039 is the first bad commit
commit 3e1515898545b0ed9e1f0794800c07061c8c8039
Author: Peter Hutterer <email address hidden>
Date: Thu Apr 18 10:32:11 2013 +1000

    dix: drop DeviceIntRec's activeGrab struct