Comment 0 for bug 1934759

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

[Impact]
Found this issue while debugging missing tests with bug 1934282.

On Bionic there are 3 scripts that are not in the Makefile of the kselftests/net:
$ for file in $(ls *.sh); do grep -q $file Makefile || echo $file; done
fib-onlink-tests.sh
in_netns.sh
msg_zerocopy.sh

[Fix]
* 830669e691464c selftests/net: enable msg_zerocopy test
* a52b839752aab7 selftests: Add fib-onlink-tests.sh to TEST_PROGS
* 5ff9c1a3dd92d2 selftests: net: add in_netns.sh to TEST_PROGS
* 9faedd643fd9f3 selftests: net: add in_netns.sh TEST_GEN_PROGS_EXTENDED

For the in_netns.sh it's not causing any issue to us when being called by run_afpackettests, but I think it's no harm to fix it to reduce confusions.

[Test]
Run the "net" test suite in the kselftest directory from a patched source tree. fib-onlink-tests.sh and msg_zerocopy.sh tests will be executed.

[Where problems could occur]
This change will bring in more test for our SRU, we might see new failures because of these test in the future.