some js files use tabs, others spaces for indentation

Bug #1240682 reported by Kyle Nitzsche on 2013-10-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu HTML5 UI SDK
High
Adnane Belmadiaf
ubuntu-html5-theme (Ubuntu)
Undecided
Unassigned

Bug Description

Not sure if there is an "official" code style guide for this project, but the js files are inconsistent, which makes them harder to edit.

Here's a sample of how lists.js appears now in vim:

    var __addUlIfNotFound = function(list) {
>.if (list) {
>. var uls = list.querySelectorAll('ul');
>. if (uls == null || uls.length == 0) {
>.>.var ul = document.createElement('ul');
>.>.list.appendChild(ul);
>. }
>.}

The ">" chars are tabs.

Now using four spaces indentation: core.js dialogs.js fast-buttons.js popovers.js toolbars.js

Now Using Tab indentation: list.js. pagestack.js button.js

Related branches

summary: - some js files use tabs, other spaces for indentation
+ some js files use tabs, others spaces for indentation
Adnane Belmadiaf (daker) on 2013-10-16
Changed in ubuntu-html5-theme:
status: New → Triaged
importance: Undecided → High
Adnane Belmadiaf (daker) on 2013-10-19
Changed in ubuntu-html5-theme:
assignee: nobody → Adnane Belmadiaf (daker)
Adnane Belmadiaf (daker) on 2013-10-19
Changed in ubuntu-html5-theme:
status: Triaged → In Progress
Revision history for this message
Adnane Belmadiaf (daker) wrote :

Hi Kyle can you please take a look at this ?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-html5-theme at revision 89, scheduled for release in ubuntu-html5-theme, milestone Unknown

Changed in ubuntu-html5-theme:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-html5-theme - 0.1+14.04.20140107-0ubuntu1

---------------
ubuntu-html5-theme (0.1+14.04.20140107-0ubuntu1) trusty; urgency=low

  [ Adnane Belmadiaf ]
  * s/parentNode/parendNode Spaces instead of tabs. (LP: #1241215)
  * Add option selector widget. (LP: #1232533)

  [ daker ]
  * Passe the UI variable name so we will not lock the variable. (LP:
    #1222878)
  * Made variable declaration locale. (LP: #1222881)
  * Fixed z-index for the list items aside. (LP: #1223973)
  * s/parentNode/parendNode Spaces instead of tabs. (LP: #1241215)
  * Space instead of tab. (LP: #1240682)
  * Made list items with headers differentes. (LP: #1246446)
  * Updated the progressbar component to match the design.
  * Move tabs closer to what they should be, Expand API to match the QML
    one (at least at the Tabs level), .
  * Add option selector widget. (LP: #1232533)

  [ Kyle Nitzsche ]
  * Add button id to "Invalid button ID" error message .
  * This MR does three main things: 1) Implements yuidoc comments in all
    js files to support API doc generation, and provides yuidoc assets
    (theme dir and json file) needed to build the API docs. Bug LP:
    #1241029 3) Provides JS classes for shape and page with
    corresponding UbuntuUI prototype constructor functions. Bug LP:
    #1243248 4) Adds a getEl(UbuntuUIObject) to return the element for
    any Ubuntu class. Also LP: #1243248. (LP: #1243248, #1241029)

  [ Colin Watson ]
  * Make ubuntu-html5-theme Multi-Arch: foreign.

  [ Alexandre Abreu ]
  * Fix exec path in app-gallery app desktop file. (LP: #1235321)
  * Add convenient element() function to most widgets ... (we might want
    to factor those out in a second step).
  * Move tabs closer to what they should be, Expand API to match the QML
    one (at least at the Tabs level), .
  * Add HTML5 webapp container package.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 98
 -- Ubuntu daily release <email address hidden> Tue, 07 Jan 2014 23:46:53 +0000

Changed in ubuntu-html5-theme (Ubuntu):
status: New → Fix Released
Adnane Belmadiaf (daker) on 2014-03-25
Changed in ubuntu-html5-theme:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers