some js files use tabs, others spaces for indentation
Bug #1240682 reported by
Kyle Nitzsche
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu HTML5 UI SDK |
Fix Released
|
High
|
Adnane Belmadiaf | ||
ubuntu-html5-theme (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Not sure if there is an "official" code style guide for this project, but the js files are inconsistent, which makes them harder to edit.
Here's a sample of how lists.js appears now in vim:
var __addUlIfNotFound = function(list) {
>.if (list) {
>. var uls = list.querySelec
>. if (uls == null || uls.length == 0) {
>.>.var ul = document.
>.>.list.
>. }
>.}
The ">" chars are tabs.
Now using four spaces indentation: core.js dialogs.js fast-buttons.js popovers.js toolbars.js
Now Using Tab indentation: list.js. pagestack.js button.js
Related branches
lp:~daker/ubuntu-html5-theme/fix.1240682
- PS Jenkins bot: Approve (continuous-integration)
- Kyle Nitzsche: Needs Fixing
- Ubuntu HTML5 Theme Developers: Pending requested
-
Diff: 549 lines (+231/-233)3 files modified0.1/ambiance/js/buttons.js (+9/-9)
0.1/ambiance/js/list.js (+132/-134)
0.1/ambiance/js/pagestacks.js (+90/-90)
summary: |
- some js files use tabs, other spaces for indentation + some js files use tabs, others spaces for indentation |
Changed in ubuntu-html5-theme: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in ubuntu-html5-theme: | |
assignee: | nobody → Adnane Belmadiaf (daker) |
Changed in ubuntu-html5-theme: | |
status: | Triaged → In Progress |
Changed in ubuntu-html5-theme: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Kyle can you please take a look at this ?