Comment 31 for bug 1551283

Tim Lunn (darkxst) wrote :

I've still not tested, but those patches look mostly fine from GNOME side.

However not really sure if the Flashback stuff is correct (edubuntu guys maintain that), but note on flashback is now using

XDG_CURRENT_DESKTOP=GNOME-Flashback:Unity

It is still using unity-settings-daemon/unity-control-center and presumably language-selector-gnome, so I guess it just uses the same config as Unity does? Now I wouldnt be surprised if there are snippets of code all over the place that don't support the above format, since they never broke on core ubuntu desktop.

Otherwise
+ if os.environ.get('XDG_CURRENT_DESKTOP')[-5:] in ['Unity', 'MATE', 'GNOME'] \
+ or locale.getlocale(locale.LC_CTYPE)[0][:3] in ['zh_', 'ja_', 'ko_', 'vi_']:

os.environ.get('XDG_CURRENT_DESKTOP').split(':')[-1]

Would seem a little safer with the know use-cases

++if [ "$XDG_CURRENT_DESKTOP" = 'Unity' -o "$XDG_CURRENT_DESKTOP" = 'MATE' -o "${XDG_CURRENT_DESKTOP##*:}" = 'GNOME' ]; then

that won't match for Flashback (I don't know if its meant to though?)