Comment 4 for bug 379205

Revision history for this message
Rocky Road (m-baert) wrote :

I checked again just in case I had messed thes patches.

The branch lp:~m-baert/ubuntu-drupal-theme/theme-patches was created
on your request specifically to apply the patches and tests the
results, which are still displayed on
http://sandbox.rocky-shore.net/drupal/ (login as "UD-tester", password
"loco", to enable the theme).

The revision 96 is interesting from a testing and versioning point of
view because it contains all major code structural changes, while NOT
changing the visual result. Please report to me it it was the case.

Here are the commands you should be able to reproduce:

----
pushd /tmp

# from bug #379084 : Replace inline css with suitable classes
wget http://launchpadlibrarian.net/27023257/replace-inline-css.patch

# from bug #379205: Columns layout and visibility
wget http://launchpadlibrarian.net/27029798/columns-layout.patch
wget http://launchpadlibrarian.net/27029342/columns-css.php

# Now checkout the branch, and check the patches
bzr branch lp:~m-baert/ubuntu-drupal-theme/theme-patches

bzr diff -r95..96 theme-patches > r95-96.patch
diff replace-inline-css.patch r95-96.patch

bzr diff -r96..97 theme-patches > r96-97.patch
diff columns-layout.patch r96-97.patch

# In both cases, only source files timestamps differ

----

The merge request you received should contain a patch file equivalent
to that obtained with:

bzr diff -r95..98 theme-patches > r95-98.patch

Using it directly would IMHO just help you NOT understanding the
changes.

All I see I could have done better is pushing an intermediate revision
between 96 and 97, where only illegal or orphans rules would be
removed, so that no visual difference should appear.

But is it worth ?