client lib Download class should be more mockable
Bug #1278789 reported by
Mike McCracken
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-download-manager |
Fix Released
|
Undecided
|
Manuel de la Peña | ||
| ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
because Ubuntu:
Workarounds in client apps are not great, involving verbose wrappers or other stuff.
Ideally those methods could be changed, enabling easy mocking.
Related branches
lp:~mandel/ubuntu-download-manager/abstract-classes
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 3548 lines (+1635/-809)53 files modifieddebian/libubuntu-download-manager-common-dev.install (+1/-0)
docs/com.canonical.applications.download.xml (+5/-0)
docs/com.canonical.applications.group_download.xml (+24/-0)
docs/com.canonical.applications.testing.download_manager.xml (+5/-0)
ubuntu-download-manager-client-tests/test_download.cpp (+35/-0)
ubuntu-download-manager-client-tests/test_download.h (+2/-0)
ubuntu-download-manager-client/ubuntu-download-manager-client.pro (+4/-1)
ubuntu-download-manager-client/ubuntu/download_manager/download.h (+74/-0)
ubuntu-download-manager-client/ubuntu/download_manager/download_impl.cpp (+218/-330)
ubuntu-download-manager-client/ubuntu/download_manager/download_impl.h (+36/-34)
ubuntu-download-manager-client/ubuntu/download_manager/download_interface.h (+3/-2)
ubuntu-download-manager-client/ubuntu/download_manager/error.cpp (+69/-1)
ubuntu-download-manager-client/ubuntu/download_manager/error.h (+33/-5)
ubuntu-download-manager-client/ubuntu/download_manager/manager.cpp (+52/-0)
ubuntu-download-manager-client/ubuntu/download_manager/manager.h (+87/-0)
ubuntu-download-manager-client/ubuntu/download_manager/manager_impl.cpp (+203/-342)
ubuntu-download-manager-client/ubuntu/download_manager/manager_impl.h (+27/-30)
ubuntu-download-manager-client/ubuntu/download_manager/manager_pendingcall_watcher.cpp (+3/-3)
ubuntu-download-manager-common/ubuntu-download-manager-common.pro (+4/-2)
ubuntu-download-manager-common/ubuntu/download_manager/auth_error_struct.cpp (+92/-0)
ubuntu-download-manager-common/ubuntu/download_manager/auth_error_struct.h (+62/-0)
ubuntu-download-manager-common/ubuntu/download_manager/metatypes.h (+2/-1)
ubuntu-download-manager-priv/downloads/download_adaptor.h (+7/-2)
ubuntu-download-manager-priv/downloads/file_download.cpp (+22/-8)
ubuntu-download-manager-priv/downloads/file_download.h (+2/-0)
ubuntu-download-manager-priv/downloads/group_download.cpp (+54/-2)
ubuntu-download-manager-priv/downloads/group_download.h (+13/-2)
ubuntu-download-manager-priv/downloads/group_download_adaptor.cpp (+11/-11)
ubuntu-download-manager-priv/downloads/group_download_adaptor.h (+27/-3)
ubuntu-download-manager-priv/downloads/manager.cpp (+1/-0)
ubuntu-download-manager-priv/system/network_reply.cpp (+7/-2)
ubuntu-download-manager-priv/system/network_reply.h (+2/-1)
ubuntu-download-manager-test-lib/ubuntu-download-manager-test-lib.pro (+4/-2)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/daemon_testcase.cpp (+21/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/daemon_testcase.h (+1/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_daemon.cpp (+7/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_daemon.h (+1/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_file_download.cpp (+21/-4)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_file_download.h (+3/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_interface.h (+9/-2)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_manager.cpp (+12/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_manager.h (+1/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_manager_adaptor.cpp (+6/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/client/testing_manager_adaptor.h (+8/-2)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/download.cpp (+21/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/download.h (+4/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/group_download.cpp (+81/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/group_download.h (+50/-0)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/network_reply.cpp (+1/-1)
ubuntu-download-manager-tests/downloads/test_download.cpp (+72/-16)
ubuntu-download-manager-tests/downloads/test_download.h (+2/-0)
ubuntu-download-manager-tests/downloads/test_group_download.cpp (+113/-0)
ubuntu-download-manager-tests/downloads/test_group_download.h (+10/-0)
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-download-manager: | |
| status: | New → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-
---------------
ubuntu-
[ Manuel de la Peña ]
* Provide pure abstract classes to simplify testing. (LP: #1278789)
[ Manuel de la Pena ]
* If proxy or server authentication is needed the download interface
raises an authentication error signal. (LP: #1278982)
* Add auth errors to the client lib. (LP: #1279854)
* Fwd the single file auth errors to as group download errors. (LP:
#1279856)
* Fix login and allow to pass the path via the command line. (LP:
#1278779)
* Improve logs. (LP: #1279425)
* Provide pure abstract classes to simplify testing. (LP: #1278789)
-- Ubuntu daily release <email address hidden> Thu, 20 Feb 2014 13:12:24 +0000