Auth signal errors are not exposed via the dbus api and are shown as simple network errors
Bug #1278982 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
| ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The auth and proxy auth errors are not exposed via the dbus api making them simple network errors something that is very confusing for the clients.
Related branches
lp:~mandel/ubuntu-download-manager/fwd-auth-errors
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 654 lines (+282/-33)15 files modifieddebian/libubuntu-download-manager-common-dev.install (+1/-0)
docs/com.canonical.applications.download.xml (+5/-0)
ubuntu-download-manager-common/ubuntu-download-manager-common.pro (+4/-2)
ubuntu-download-manager-common/ubuntu/download_manager/auth_error_struct.cpp (+92/-0)
ubuntu-download-manager-common/ubuntu/download_manager/auth_error_struct.h (+62/-0)
ubuntu-download-manager-common/ubuntu/download_manager/metatypes.h (+2/-1)
ubuntu-download-manager-priv/downloads/download_adaptor.h (+7/-2)
ubuntu-download-manager-priv/downloads/file_download.cpp (+22/-8)
ubuntu-download-manager-priv/downloads/file_download.h (+2/-0)
ubuntu-download-manager-priv/downloads/manager.cpp (+1/-0)
ubuntu-download-manager-priv/system/network_reply.cpp (+7/-2)
ubuntu-download-manager-priv/system/network_reply.h (+2/-1)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/network_reply.cpp (+1/-1)
ubuntu-download-manager-tests/downloads/test_download.cpp (+72/-16)
ubuntu-download-manager-tests/downloads/test_download.h (+2/-0)
| summary: |
- Auth signal errors are not exposed via the dbud api and are shown as + Auth signal errors are not exposed via the dbus api and are shown as simple network errors |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-download-manager: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-
---------------
ubuntu-
[ Manuel de la Peña ]
* Provide pure abstract classes to simplify testing. (LP: #1278789)
[ Manuel de la Pena ]
* If proxy or server authentication is needed the download interface
raises an authentication error signal. (LP: #1278982)
* Add auth errors to the client lib. (LP: #1279854)
* Fwd the single file auth errors to as group download errors. (LP:
#1279856)
* Fix login and allow to pass the path via the command line. (LP:
#1278779)
* Improve logs. (LP: #1279425)
* Provide pure abstract classes to simplify testing. (LP: #1278789)
-- Ubuntu daily release <email address hidden> Thu, 20 Feb 2014 13:12:24 +0000