Local download paths are not built with apparmor encapsulation in mind
Bug #1222914 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Critical
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The local path downlaods should be using the app id if available via apparmor to choose the location of the download.
Related branches
lp:~mandel/ubuntu-download-manager/use-appid-local-path
- PS Jenkins bot: Approve (continuous-integration)
- Mike McCracken (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 2205 lines (+809/-275)25 files modifiedlibubuntudownloadmanager/apparmor.cpp (+82/-26)
libubuntudownloadmanager/apparmor.h (+11/-2)
libubuntudownloadmanager/download.cpp (+30/-2)
libubuntudownloadmanager/download.h (+6/-0)
libubuntudownloadmanager/download_factory.cpp (+97/-14)
libubuntudownloadmanager/download_factory.h (+18/-0)
libubuntudownloadmanager/group_download.cpp (+19/-6)
libubuntudownloadmanager/group_download.h (+4/-0)
libubuntudownloadmanager/single_download.cpp (+26/-40)
libubuntudownloadmanager/single_download.h (+6/-0)
ubuntu-download-manager-tests/fake_apparmor.cpp (+45/-21)
ubuntu-download-manager-tests/fake_apparmor.h (+15/-2)
ubuntu-download-manager-tests/fake_download.cpp (+8/-4)
ubuntu-download-manager-tests/fake_download.h (+24/-20)
ubuntu-download-manager-tests/fake_download_factory.cpp (+66/-6)
ubuntu-download-manager-tests/fake_download_factory.h (+14/-0)
ubuntu-download-manager-tests/test_download.cpp (+153/-78)
ubuntu-download-manager-tests/test_download.h (+6/-0)
ubuntu-download-manager-tests/test_download_factory.cpp (+34/-0)
ubuntu-download-manager-tests/test_download_factory.h (+2/-0)
ubuntu-download-manager-tests/test_download_queue.cpp (+6/-2)
ubuntu-download-manager-tests/test_download_queue.h (+2/-0)
ubuntu-download-manager-tests/test_downloads_db.cpp (+5/-5)
ubuntu-download-manager-tests/test_group_download.cpp (+125/-47)
ubuntu-download-manager-tests/test_group_download.h (+5/-0)
Changed in ubuntu-download-manager: | |
status: | Triaged → In Progress |
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 124, scheduled for release in ubuntu- download- manager, milestone 0.3