Local fs destination is ignored in group downloads
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
High
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The wiki documentation says:
createDownloadG
This method allows the creation of a GroupDownload object that will allow to perform the download of a collection of urls so that they are performed as a single atomic operation.
Arguments
IN Array<GroupDown
The url to be downloaded. If this value is empty then the hash will not be checked.
The local file where the download will be stored, please see Download manager special use cases.
The hash of the download.
But with a "local file" destination in /tmp, the files are not moved there after successful download. I get a 'finished' signal with a local_path pointing into ~/.local/
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Mike McCracken (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 2205 lines (+809/-275)25 files modifiedlibubuntudownloadmanager/apparmor.cpp (+82/-26)
libubuntudownloadmanager/apparmor.h (+11/-2)
libubuntudownloadmanager/download.cpp (+30/-2)
libubuntudownloadmanager/download.h (+6/-0)
libubuntudownloadmanager/download_factory.cpp (+97/-14)
libubuntudownloadmanager/download_factory.h (+18/-0)
libubuntudownloadmanager/group_download.cpp (+19/-6)
libubuntudownloadmanager/group_download.h (+4/-0)
libubuntudownloadmanager/single_download.cpp (+26/-40)
libubuntudownloadmanager/single_download.h (+6/-0)
ubuntu-download-manager-tests/fake_apparmor.cpp (+45/-21)
ubuntu-download-manager-tests/fake_apparmor.h (+15/-2)
ubuntu-download-manager-tests/fake_download.cpp (+8/-4)
ubuntu-download-manager-tests/fake_download.h (+24/-20)
ubuntu-download-manager-tests/fake_download_factory.cpp (+66/-6)
ubuntu-download-manager-tests/fake_download_factory.h (+14/-0)
ubuntu-download-manager-tests/test_download.cpp (+153/-78)
ubuntu-download-manager-tests/test_download.h (+6/-0)
ubuntu-download-manager-tests/test_download_factory.cpp (+34/-0)
ubuntu-download-manager-tests/test_download_factory.h (+2/-0)
ubuntu-download-manager-tests/test_download_queue.cpp (+6/-2)
ubuntu-download-manager-tests/test_download_queue.h (+2/-0)
ubuntu-download-manager-tests/test_downloads_db.cpp (+5/-5)
ubuntu-download-manager-tests/test_group_download.cpp (+125/-47)
ubuntu-download-manager-tests/test_group_download.h (+5/-0)
Changed in ubuntu-download-manager: | |
importance: | Undecided → High |
assignee: | nobody → Manuel de la Peña (mandel) |
status: | New → In Progress |
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
The problem with this is that there's no way I can accurately move the files from the actual destination to the intended destination. The best I can do - and this is in practice *highly* fragile - is match the last path component of the actual destination against the last path component of the requested url.