> Don't we still need to fix the cli layout so that ./run-tests cli works?
There are several issues with the current layout of the project:
- we have 2 levels of directories for each component: one inside the project and one below to hold python files for the component,
- we have tests that involves several components and cannot be stored in a component dir.
So it's more about making sure we have unique test IDs than making 'run-tests cli' works since run-tests doesn't care about how the tests are named, leaving the user control the layout.
Since we have a different directory for each component, we have to add them all to PYTHONPATH which can create collisions.
You encountered one with run_worker, I encountered some others while working on the integration tests.
Hard-coding relationships between tests and components inside run-tests is not the way to go, that will just create additional maintenance for no benefits.
> Why is this invalid?
because run-tests works as designed in that case.
> Don't we still need to fix the cli layout so that ./run-tests cli works?
There are several issues with the current layout of the project:
- we have 2 levels of directories for each component: one inside the project and one below to hold python files for the component,
- we have tests that involves several components and cannot be stored in a component dir.
So it's more about making sure we have unique test IDs than making 'run-tests cli' works since run-tests doesn't care about how the tests are named, leaving the user control the layout.
Since we have a different directory for each component, we have to add them all to PYTHONPATH which can create collisions.
You encountered one with run_worker, I encountered some others while working on the integration tests.
Hard-coding relationships between tests and components inside run-tests is not the way to go, that will just create additional maintenance for no benefits.