Long click creates event in disabled calendar

[Cédric Bellegarde]

Steps to reproduce:
 - Disable default (Personal) calendar.
 - Long press somewhere in week view.
 - Nothing *appears* to happen, but in the indicator an "Untitled" event appears.

This occurs because the Calendar app actually creates a new event in the Personal calendar, despite not displaying it.

Additionally, when creating a new event normally, the default calendar is the Personal calendar despite being disabled.

Expected behaviour:
At a minimum, the default calendar for a new event should be an enabled calendar.

Other improvements that could be made (maybe needs designer feedback):
If more than one calendar is listed, it should be possible to set the default for new events.
If all (editable) calendars are disabled, we should probably disable the long-press-create.
The indicator and event scopes could avoid displaying events from disabled calendars.

[Kyle Nitzsche (knitzsche)]

Hi,

Can you take a picture and attached it?

The Today scope just displays what the Events scope (called "Upcoming" in Today settings) provides it, so I don't think this is a Today scope bug. I'll mark it invalid on Today.

I will create "also affects savilerow" to indicate a possible connection to the Events scope.

I wonder if this is an underlying issue with Evolution server though. Can someone from the Calendar app team comment please?

[Cédric Bellegarde (gnumdk)]

You're right, it's a bug in events scope.

[Cédric Bellegarde (gnumdk)]

Seems to happen when creating/removing events from ubuntu-calendar-app...

Here a broken ~/.local/share/evolution/calendar/system/calendar.ics

BEGIN:VCALENDAR
CALSCALE:GREGORIAN
PRODID:-//Ximian//NONSGML Evolution Calendar//EN
VERSION:2.0
X-EVOLUTION-DATA-REVISION:2015-07-28T10:25:31.407132Z(1)
BEGIN:VEVENT
UID:20150728T102531Z-27202-32011-1595-1@ubuntu-phablet
DTSTAMP:20150728T102531Z
DTSTART:20150806T160000Z
DTEND:20150806T170000Z
SUMMARY:Sans titre
COMMENT:X-CAL-DEFAULT-EVENT
CREATED:20150728T102531Z
LAST-MODIFIED:20150728T102531Z
END:VEVENT
BEGIN:VEVENT
UID:20150728T102531Z-27202-32011-1595-3@ubuntu-phablet
DTSTAMP:20150728T102531Z
DTSTART:20150806T160000Z
DTEND:20150806T170000Z
SUMMARY:Sans titre
COMMENT:X-CAL-DEFAULT-EVENT
CREATED:20150728T102531Z
LAST-MODIFIED:20150728T102531Z
END:VEVENT
END:VCALENDAR

[Chris Wayne (cwayne)]

This sounds more like a bug in EDS actually, as the events scope simply pulls its data from there (as does the dateime-indicator and calendar app). So if it's happening in all three, it's unlikely to be the events scope at fault

[Cédric Bellegarde (gnumdk)]

Only datetime show events from this file.

[Yuan-Chen Cheng (ycheng-twn)]

@Cédric,

1.can you reproduce it ?
2. if yes, how is the step to reproduce and what is the failed rate ?
3. what's the firmware version you last see it ? (past output of system-img-cli -i)

Thanks a lot !

[Cédric Bellegarde (gnumdk)]

OK, I think I understand what is happening.

More a usability issue.

Personnal calendar is disabled here as I use a Google calendar. But when creating an event, personnal calendar is selected by default.

I just found that long push in calendar create a no title event in personnal calendar so not visible for me (as it is disabled).

So it is an issue in calendar app.

[Kunal Parmar (pkunal-parmar)]

yes, currently calendar creates no title events on long press. We need to see how to handle this case with UI designer.

[Sam Bull (dreamsorcerer)]

Updated bug description with information from bug #1494711.

[Kyle Nitzsche (knitzsche)]

This looks like the calendar app, so it is not related to the savilerow project. Marking invalid in savilerow.

[Bill Filler (bfiller)]

@artmello
I think we should do a couple of things here:
1. First implement the settings for a default calendar (https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1373945)
2. When create a new event, use the default calendar
3. If the user disables the default calendar from the UI, make them select another calendar as the default before proceeding, that way there is always a default. If they try to disable the last calendar do not allow them.

This should insure that there is always a default calendar when creating events.

[Renato Araujo Oliveira Filho (renatofilho)]

Part of this problem was fixed in my last commit.

The current behavior can be found here [1]:
1 - It get the default calendar, check if it is enabled and return it
2- If default calendar is null or disable it return the first enabled calendar
3- If all calendars are disabled it returns the first calendar.

[1]http://bazaar.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/trunk/view/head:/EventListModel.qml#L91